Docs: Update couchdb/README.md - change cookeAuthSecret to erlangCookie and make code blocks easier to copy via copy button on github
#132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de blocks easier to copy via copy button on github
jessebot
commented
Nov 30, 2023
willholley
requested changes
May 21, 2024
Member
willholley
left a comment
willholley
left a comment
There was a problem hiding this comment.
Thanks for the PR! As per my review comment, I think the change to the secrets documentation is an "and" rather than an "or", since both secret values are required.
jessebot
commented
May 29, 2024
jessebot
commented
May 29, 2024
jessebot
commented
May 29, 2024
jessebot
commented
May 29, 2024
jessebot
commented
May 29, 2024
jessebot
commented
May 29, 2024
…Cookie are required
willholley
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This updates
cookeAuthSecrettoerlangCookiein the README for the helm chart directory, as that is what couchdb looks for in the secret can pre-generate.I've also updated the code blocks to not have
$in front of each command, so that users can more easily copy and paste the commands to test them. This is particularly helpful for users with disabilities as they don't need to mind the space and dollar sign when trying out the commands in the docs.Which issue this PR fixes
Special notes for your reviewer:
Thanks for maintaining this helm chart!
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.