Skip to content

Add hostname annotation to set loadbalancer ingress hostname #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weizhouapache merged 1 commit into from
May 28, 2024
Merged

Add hostname annotation to set loadbalancer ingress hostname #48

weizhouapache merged 1 commit into from
May 28, 2024

Conversation

@hrak
Copy link
Contributor

@hrak hrak commented May 5, 2023

This fixes problems with kube-proxy in ipvs mode considering the loadbalancer IP as local to the node (causing loadbalanced services to be unreachable).

See kubernetes/kubernetes#66607

This can also be used to access PROXY proto service from the inside.

@hrak
Add hostname annotation to set lb ingress hostname
49d46df 
This fixes problems with kube-proxy in ipvs mode considering the lb IP as local to the node
See kubernetes/kubernetes#66607
This can also be used to access PROXY proto service from the inside
@hrak hrak mentioned this pull request Mar 12, 2024
Merged
vishesh92
vishesh92 approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

weizhouapache
weizhouapache approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@hrak
can you describe how to use/test it ?

@vishesh92
Copy link
Member

vishesh92 commented May 22, 2024 •
edited
Loading

Did some manual testing. After this change, I have verified that the service created has external IP equal to hostname set in service.beta.kubernetes.io/cloudstack-load-balancer-hostname. And the same hostname is also set in the status of the service.

@weizhouapache
Copy link
Member

weizhouapache commented May 22, 2024

Did some manual testing. After this change, I have verified that the service created has external IP equal to hostname set in service.beta.kubernetes.io/cloudstack-load-balancer-hostname. And the same hostname is also set in the status of the service.

cool, thanks @vishesh92
can you test ipvs mode if the issue can be reproduced and fixed by this change ?

@weizhouapache weizhouapache added this to the 1.1.0 milestone May 22, 2024
@vishesh92
Copy link
Member

vishesh92 commented May 22, 2024

@weizhouapache I am not able to reproduce the issue, but I can verify the functionality is working as expected. For why hostname is required as part of the loadbalancerStatus, check: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#loadbalanceringress-v1-core

@weizhouapache weizhouapache merged commit 0150bf5 into apache:main May 28, 2024
@hrak hrak deleted the ingress_hostname branch September 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishesh92 vishesh92 vishesh92 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hrak @vishesh92 @weizhouapache