Strip domain from node.Name before matching with vm names #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hans Rakers <h.rakers@global.leaseweb.com>
vishesh92
approved these changes
May 22, 2024
Member
vishesh92
left a comment
vishesh92
left a comment
There was a problem hiding this comment.
code lgtm. The changes shouldn't cause an issue either since VMs in ACS can't have . in their name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes node.Name can contain a FQDN instead of just a hostname in some setups. This PR makes sure to strip the domain part before trying to match with VM names from the CS API, since CloudStack does not have the concept of FQDN VM names.
It also adds some sanity checking in case verifyHosts is about to return an empty hostIDs array or empty networkID (this is how i ran into this issue)