-
Notifications
You must be signed in to change notification settings - Fork 120
Restart system vms to MASTER #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@andrijapanicsb - I've merged 4.13 branch into master, can you rebase this PR to see what (if any) 'changes' are left |
|
Done @PaulAngus |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr80 Build Log Output: No log errors found to report. |
PaulAngus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Should this not go into 4.13 so that we can forward merge? |
|
@PaulAngus I've made originally a PR against 4.13 as well - currently contains identical commits - so if you are OK, we can merge both PR? |
|
Are you saying that the content of the commit is the same or that the commit SHA is the same? @andrijapanicsb |
|
merged to 4.13, merged forward to master - so closing this one. |

@PaulAngus this one contains same "include rebooting systemsVM" as PR #79 , but here also your own changes around guest OS customisation (and some headers and references chagnes) are included.
I believe this is all required for master.
Later we'll need to update versions to 4.14 etc (one it's out)