-
Notifications
You must be signed in to change notification settings - Fork 120
Configure Root disk size via Service Offering #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DaanHoogland
merged 4 commits into
apache:master
from
GabrielBrascher:resize-root-serviceoffering
Dec 11, 2020
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5638e3f
Configure Root disk size via Service Offering
GabrielBrascher b2a2f06
Service Offerings with Root size of 0GB do not change the disk size t…
GabrielBrascher 42fc3a6
Add '.. note::' block
GabrielBrascher e26e9f5
Add `Root Disk size (optional)` on Service Offering section
GabrielBrascher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -617,6 +617,40 @@ To resize a volume: | |
|
|
||
| #. Click OK. | ||
|
|
||
| Root Volume size defined via Service Offering | ||
| ~~~~~~~~~~~~~~~~ | ||
|
|
||
| If a Service Offering is created with a root disk size, then resizing the Root volume is possible only by resizing the VMs service offering. | ||
|
|
||
| Service offering Root resizing constrains: | ||
|
|
||
| #. Users cannot deploy VMs with custom root disk size when using such offerings | ||
|
|
||
| #. Users cannot resize the VM root disk size when using such offerings | ||
|
|
||
| #. The Root Volume of such VMs can only be resized when changing to another Service Offering with a Root disk size equals or larger than the current one. | ||
|
|
||
| #. Users can change the VM offering to a service offering with a Root size of 0GB (default) and then customize the volume size. | ||
|
|
||
| The following table shows possible combinations of Service offering supported resizing based on the offering Root disk size: | ||
|
|
||
| +---+----------------------------+---------------------------+-------------------------------+ | ||
| | # | Service Offering Root size | new Service Offering Root | Does support offering resize? | | ||
| +---+----------------------------+---------------------------+-------------------------------+ | ||
| | 1 | 0GB (default) | Any | YES | | ||
| +---+----------------------------+---------------------------+-------------------------------+ | ||
| | 2 | 5GB | 5GB | YES | | ||
| +---+----------------------------+---------------------------+-------------------------------+ | ||
| | 3 | 5GB | 10GB | YES | | ||
| +---+----------------------------+---------------------------+-------------------------------+ | ||
| | 4 | 10GB | 5GB | NO | | ||
| +---+----------------------------+---------------------------+-------------------------------+ | ||
| | 5 | Any | 0GB | YES | | ||
| +---+----------------------------+---------------------------+-------------------------------+ | ||
|
|
||
| .. note:: | ||
| Shrinking the Root disk is not supported via the service offering resizing workflow. All the combinations above assume a transition to Root disks with size equals or bigger than the original. | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DaanHoogland does this disclaimer suffice your concerns? |
||
| Service Offerings with Root size of 0GB do not change the disk size to Zero and indicates that the offering do not enforces a Root disk size. | ||
|
|
||
| Reset VM to New Root Disk on Reboot | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you state below that shrinking is not supported, I think an extra remark on this line is in order. It certainly implies that shrinking is allowed.