Skip to content

Conversation

@GabrielBrascher
Copy link
Member

This documentation is based on PR apache/cloudstack#4341: Allow to configure root disk size via Service Offering (diskoffering of type Service).

@GabrielBrascher GabrielBrascher force-pushed the resize-root-serviceoffering branch 4 times, most recently from 99953db to a1b1741 Compare October 9, 2020 19:48
Based on PR at apache/cloudstack repository:
 - #4341: Allow to configure root disk size via Service Offering (diskoffering of type Service).
@GabrielBrascher GabrielBrascher force-pushed the resize-root-serviceoffering branch from a1b1741 to 5638e3f Compare October 9, 2020 19:49
@GabrielBrascher GabrielBrascher marked this pull request as ready for review October 9, 2020 19:50
@GabrielBrascher
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162

Build Log Output:

No log errors found to report.

@GabrielBrascher
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162

Build Log Output:

No log errors found to report.

@GabrielBrascher GabrielBrascher self-assigned this Oct 12, 2020
+---+----------------------------+---------------------------+-------------------------------+
| 4 | 10GB | 5GB | NO |
+---+----------------------------+---------------------------+-------------------------------+
| 5 | Any | 0GB | YES |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you state below that shrinking is not supported, I think an extra remark on this line is in order. It certainly implies that shrinking is allowed.

@rohityadavcloud rohityadavcloud added this to the 4.15 milestone Nov 11, 2020
@GabrielBrascher
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162//

Build Log Output:

No log errors found to report.//

@GabrielBrascher
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

+---+----------------------------+---------------------------+-------------------------------+

.. note::
Shrinking the Root disk is not supported via the service offering resizing workflow. All the combinations above assume a transition to Root disks with size equals or bigger than the original.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland does this disclaimer suffice your concerns?

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162//

Build Log Output:

No log errors found to report.//

@GabrielBrascher
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162//

Build Log Output:

No log errors found to report.//

@DaanHoogland
Copy link
Contributor

@GabrielBrascher is this good to go (That extra not should do for now)?

@GabrielBrascher
Copy link
Member Author

@DaanHoogland I think it is good to go. Please let me know if there is anything still missing or if the text is not clear about the disk offering root disk size.

Thanks for the review!

@DaanHoogland DaanHoogland merged commit 5d6ef85 into apache:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants