Skip to content

Support migration of VM imported from a remote host #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vishesh92 merged 1 commit into from
Jun 24, 2024
Merged

Support migration of VM imported from a remote host #9259

vishesh92 merged 1 commit into from
Jun 24, 2024

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Jun 14, 2024

Description

This PR fixes: #8827
Importing a VM from a remote host uses a dummy VM template which is not present on the secondary store, leading to NPEs when migrating the VM. This PR enables migrating oly the volume (not the template)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 self-assigned this Jun 14, 2024
@DaanHoogland DaanHoogland changed the base branch from main to 4.19 June 14, 2024 13:03
DaanHoogland
DaanHoogland approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone Jun 14, 2024
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jun 14, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jun 14, 2024

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jun 14, 2024

@Pearl1594 Is this live migration of the volume, or offline?

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Jun 14, 2024

live migration @sureshanaparti

@codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.37%. Comparing base (0208e09) to head (2a96d9f).
Report is 167 commits behind head on 4.19.

Files Patch % Lines
...torage/motion/StorageSystemDataMotionStrategy.java 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.19    #9259       +/-   ##
=============================================
- Coverage     30.91%   16.37%   -14.54%     
+ Complexity    34249    14581    -19668     
=============================================
  Files          5354     4857      -497     
  Lines        376094   325107    -50987     
  Branches      54696    45667     -9029     
=============================================
- Hits         116258    53244    -63014     
- Misses       244542   264286    +19744     
+ Partials      15294     7577     -7717
Flag Coverage Δ
simulator-marvin-tests 16.37% <0.00%> (-8.36%) ⬇️
uitests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti
sureshanaparti approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

blueorangutan commented Jun 14, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9960

@vishesh92
Copy link
Member

vishesh92 commented Jun 20, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jun 20, 2024

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Jun 20, 2024
@blueorangutan
Copy link

blueorangutan commented Jun 20, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10042

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jun 20, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jun 20, 2024

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2024

[SF] Trillian test result (tid-10540)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48752 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9259-t10540-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 336.68 test_safe_shutdown.py

@vishesh92
Copy link
Member

vishesh92 commented Jun 24, 2024

Tested the PR. Was able to reproduce the issue. Not able to reproduce it after this patch.

@vishesh92 vishesh92 merged commit f792684 into 4.19 Jun 24, 2024
@vishesh92 vishesh92 deleted the 8827-fix-migration-of-imported-vm-kvm branch June 24, 2024 07:16
@sureshanaparti sureshanaparti mentioned this pull request Jun 24, 2024
Closed
@DaanHoogland DaanHoogland mentioned this pull request Jul 1, 2024
Closed
11 tasks
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
@Pearl1594 @dhslove
Support migration of VM imported from a remote host (apache#9259)
81e614c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@Pearl1594 Pearl1594

Labels

component:migration component:storage status:needs-testing

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

Unable to migrate instance that came from an external KVM host

5 participants

@Pearl1594 @DaanHoogland @blueorangutan @sureshanaparti @vishesh92