Skip to content

DRS: Ensure the destination host is part of the same cluster #9245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sureshanaparti merged 2 commits into from
Jun 25, 2024
Merged

DRS: Ensure the destination host is part of the same cluster #9245

sureshanaparti merged 2 commits into from
Jun 25, 2024

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Jun 13, 2024 •
edited
Loading

Description

Fixes #8629

This PR ensures that during a DRS run, the destination host is part of the same cluster for which migration is being run.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 mentioned this pull request Jun 13, 2024
Closed
weizhouapache
weizhouapache approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@vishesh92 vishesh92 added this to the 4.19.1.0 milestone Jun 13, 2024
@codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.95%. Comparing base (034a5c8) to head (6a2936a).
Report is 24 commits behind head on 4.19.

Files Patch % Lines
...ache/cloudstack/cluster/ClusterDrsServiceImpl.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              4.19    #9245       +/-   ##
============================================
+ Coverage     4.29%   14.95%   +10.66%     
- Complexity       0    11015    +11015     
============================================
  Files          363     5378     +5015     
  Lines        29374   470095   +440721     
  Branches      5138    58572    +53434     
============================================
+ Hits          1261    70295    +69034     
- Misses       27970   392014   +364044     
- Partials       143     7786     +7643
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92
Copy link
Member Author

vishesh92 commented Jun 13, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jun 13, 2024

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92 vishesh92 linked an issue Jun 13, 2024 that may be closed by this pull request
DRS failed for cluster if have another cluster in zone #8629
Closed
shwstppr
shwstppr approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link

blueorangutan commented Jun 13, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9925

DaanHoogland
DaanHoogland approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Jun 14, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jun 14, 2024

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jun 14, 2024

[SF] Trillian test result (tid-10443)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48859 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9245-t10443-kvm-centos7.zip
Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 341.70 test_safe_shutdown.py
test_01_secure_vm_migration Error 33.66 test_vm_life_cycle.py
test_01_secure_vm_migration Error 33.66 test_vm_life_cycle.py
test_04_deploy_vnf_appliance Error 102.57 test_vnf_templates.py
test_04_deploy_vnf_appliance Error 102.57 test_vnf_templates.py
test_05_delete_vnf_template Error 0.06 test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown Error 1.16 test_vnf_templates.py

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jun 17, 2024

@blueorangutan test alma9 kvm-alma9

@blueorangutan
Copy link

blueorangutan commented Jun 17, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jun 17, 2024

[SF] Trillian test result (tid-10465)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 48927 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9245-t10465-kvm-alma9.zip
Smoke tests completed. 126 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRouterServices>:setup Error 0.00 test_routers.py
test_01_isolate_network_FW_PF_default_routes_egress_true Error 0.23 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Error 0.21 test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup Error 1.44 test_routers_network_ops.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup Error 0.36 test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup Error 0.00 test_set_sourcenat.py
test_01_redundant_vpc_site2site_vpn Failure 445.48 test_vpc_vpn.py

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jun 18, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jun 18, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jun 18, 2024

[SF] Trillian Build Failed (tid-10476)

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Jun 18, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jun 18, 2024

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jun 18, 2024

[SF] Trillian test result (tid-10481)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49012 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9245-t10481-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 341.92 test_safe_shutdown.py

sureshanaparti
sureshanaparti approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti merged commit 2bf36ef into 4.19 Jun 25, 2024
@DaanHoogland DaanHoogland deleted the drs-ensure-migration-within-cluster branch June 26, 2024 05:53
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
@vishesh92 @dhslove
DRS: Ensure the destination host is part of the same cluster (apache#…
8d29d36 
…9245)

* DRS: Ensure the destination host is part of the same cluster

* Add and fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

status:needs-testing

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

DRS failed for cluster if have another cluster in zone

7 participants

@vishesh92 @blueorangutan @rohityadavcloud @DaanHoogland @shwstppr @sureshanaparti @weizhouapache