Skip to content

ui: fix dashboard on saml user login - #9097

Merged
yadvr merged 3 commits into
apache:4.19from
shapeblue:fix-ui-saml-login
Jun 12, 2024
Merged

ui: fix dashboard on saml user login#9097
yadvr merged 3 commits into
apache:4.19from
shapeblue:fix-ui-saml-login

Conversation

@shwstppr

@shwstppr shwstppr commented May 21, 2024 •
edited by DaanHoogland
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes: #8950
Fixes: #9045

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: fix dashboard on saml user login
ba3d551 
Fixes apache#8950
Fixes apache#9045

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr linked an issue May 21, 2024 that may be closed by this pull request
Empty resources in dashboard #9045
Closed
@shwstppr

shwstppr commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

This works but will have to check how project was set in local storage earlier

@codecov

codecov Bot commented May 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (c6762f1) to head (a44cab9).
Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9097      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10989    10987       -2     
============================================
  Files          5373     5373              
  Lines        469024   469027       +3     
  Branches      57763    60852    +3089     
============================================
- Hits          70186    70178       -8     
- Misses       391069   391082      +13     
+ Partials       7769     7767       -2
Flag Coverage Δ
uitests 4.31% <ø> (-0.01%) ⬇️
unittests 15.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yadvr yadvr added this to the 4.19.1.0 milestone May 22, 2024
@yadvr

yadvr commented May 22, 2024

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

UI build failed: ✖️
(SL-JID-345)

@DaanHoogland

DaanHoogland commented May 22, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

UI build failed: ✖️
(SL-JID-346)

@shwstppr

shwstppr commented May 24, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

shwstppr
shwstppr commented May 24, 2024
View reviewed changes
Comment thread ui/src/permission.js Outdated
@shwstppr

shwstppr commented May 24, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9097 (QA-JID-351)

weizhouapache
weizhouapache reviewed May 24, 2024
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

needs testing

@shwstppr
shwstppr marked this pull request as ready for review May 27, 2024 08:24
@DaanHoogland DaanHoogland linked an issue Jun 3, 2024 that may be closed by this pull request
Dashboard doesn't update for SAML user upon login #8950
Closed
@yadvr

yadvr commented Jun 12, 2024

Copy link
Copy Markdown
Member

LGTM - let me merge this and help test against the QA server.

@yadvr
yadvr merged commit e2e46e3 into apache:4.19 Jun 12, 2024
@yadvr
yadvr deleted the fix-ui-saml-login branch June 12, 2024 11:49
@yadvr yadvr mentioned this pull request Jun 12, 2024
Closed
@yadvr

yadvr commented Jun 12, 2024

Copy link
Copy Markdown
Member

Fixed by #9097
Tested on https://qa.cloudstack.cloud/simulator/ using SAML using rick

@yadvr yadvr mentioned this pull request Jun 12, 2024
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@shwstppr @dhslove
ui: fix dashboard on saml user login (apache#9097)
268e18f 
* ui: fix dashboard on saml user login

Fixes apache#8950
Fixes apache#9045

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* Update ui/src/permission.js

---------

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizhouapache weizhouapache weizhouapache left review comments
@yadvr yadvr yadvr approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

ACS Backlog
Status: Abhishek's Bugfix List
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

Empty resources in dashboard Dashboard doesn't update for SAML user upon login

5 participants

@shwstppr @yadvr @blueorangutan @DaanHoogland @weizhouapache