Skip to content

Use parameter dcId as wrapper to prevent NPE #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
May 1, 2024
Merged

Use parameter dcId as wrapper to prevent NPE #8986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab092c0
auto unwrap was casuing an NPE
DaanHoogland Apr 26, 2024
f053582
override
DaanHoogland Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...pi/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/EndPointSelector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@ public interface EndPointSelector {

EndPoint select(DataStore store, String downloadUrl);

EndPoint findSsvm(long dcId);
EndPoint findSsvm(Long dcId);
}
3 changes: 2 additions & 1 deletion ...storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,8 @@ protected EndPoint findEndpointForImageStorage(DataStore store) {
* Finds an SSVM that can be used to execute a command.
* For zone-wide image store, use SSVM for that zone. For region-wide store, we can arbitrarily pick one SSVM to do the task.
* */
public EndPoint findSsvm(long dcId) {
@Override
public EndPoint findSsvm(Long dcId) {
List<HostVO> ssAHosts = listUpAndConnectingSecondaryStorageVmHost(dcId);
if (ssAHosts == null || ssAHosts.isEmpty()) {
return null;
Expand Down