ui: don't skip if dataview has multiple items in response #7947
Conversation
This would fix the case of multiple items return in API response for a resource such as a template or ISO in case of multi-zone env. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
requested review from
DaanHoogland,
nvazquez,
rajujith,
shwstppr and
weizhouapache
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
Verified OK on an environment with 2 zones
|
@rohityadavcloud could this fix cause regressions on PR #7846 which introduced the check? |
|
UI build: ✔️ |
|
I've tested for #7846 and can't reproduce the issue with this fix, I think this PR should address @rajujith 's issue and not cause further regression. Thank @rajujith @weizhouapache for reporting. |
|
@blueorangutan package |
|
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
Thanks @rohityadavcloud - LGTM
Codecov Report
@@ Coverage Diff @@
## 4.18 #7947 +/- ##
============================================
- Coverage 13.06% 13.06% -0.01%
+ Complexity 9097 9096 -1
============================================
Files 2720 2720
Lines 257465 257465
Branches 40146 40146
============================================
- Hits 33643 33634 -9
- Misses 219594 219604 +10
+ Partials 4228 4227 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6989 |
|
Reproduced the issue and verified it is fixed by this PR. Without this PR With this PR |
rajujith
left a comment
rajujith
left a comment
There was a problem hiding this comment.
The issue is no longer observed in environments with 2 zones.
6 participants
This would fix the case of multiple items return in API response for a resource such as a template or ISO in case of multi-zone env.
Types of changes