Skip to content

UI: fix default network is not passed to deployvm API #7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weizhouapache merged 1 commit into from
Mar 28, 2023
Merged

UI: fix default network is not passed to deployvm API #7367

weizhouapache merged 1 commit into from
Mar 28, 2023

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Mar 24, 2023

Description

This PR fixes a critical issue on UI that the default network is not passed to deployvm API, so the default network is always the first network.

This line was changed in #5080, but reverted in #5151

This issue exists in 4.17, 4.18 and main

workaround

  • create a vm on default network (do not start it)
  • add vm to other networks
  • start the vm

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov
Copy link

codecov bot commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #7367 (c352017) into 4.17 (b5c5d19) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #7367   +/-   ##
=========================================
  Coverage     10.38%   10.38%           
  Complexity     6650     6650           
=========================================
  Files          2453     2453           
  Lines        242444   242444           
  Branches      37941    37941           
=========================================
  Hits          25171    25171           
  Misses       214155   214155           
  Partials       3118     3118

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland
DaanHoogland approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, indeed a reintroduction of the bug in #5151

NuxRo
NuxRo approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud rohityadavcloud added this to the 4.18.1.0 milestone Mar 24, 2023
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Mar 24, 2023

@NuxRo @weizhouapache feel free to merge/close this when tested
@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2023

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2023

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7367 (QA-JID-65)

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 24, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2023

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2023

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5775

harikrishna-patnala
harikrishna-patnala approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 27, 2023

@NuxRo @harikrishna-patnala
can one of you guys test it ? thanks !

@kiranchavala
Copy link
Contributor

kiranchavala commented Mar 27, 2023

@blueorangutan ui

@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Mar 28, 2023

I could reproduce the issue and also the verified the fix, it is working fine. LGTM

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 28, 2023

thanks @harikrishna-patnala for the testing
merging

@weizhouapache weizhouapache merged commit 9e1c7a2 into apache:4.17 Mar 28, 2023
DaanHoogland added a commit that referenced this pull request Mar 29, 2023
@DaanHoogland
Merge release branch 4.18 to main
c2cffcc 
* 4.18:
  Fixed avoid set variables which is causing deployment failures (#7372)
  Add service ip to listManagementServers API response (#7374)
  UI: fix default network is not passed to deployvm API (#7367)
  ui: Added UEFI support flag in host details view (#7361)
  removed vulnerable workflow
kishankavala pushed a commit to shapeblue/cloudstack that referenced this pull request Apr 13, 2023
@weizhouapache @kishankavala
UI: fix default network is not passed to deployvm API (apache#7367)
9e4f3a1 
This line was changed in apache#5080, but reverted in apache#5151
@weizhouapache weizhouapache deleted the 4.17-fix-ui-default-network branch June 23, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@NuxRo NuxRo NuxRo approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@weizhouapache @rohityadavcloud @blueorangutan @kiranchavala @harikrishna-patnala @NuxRo @DaanHoogland