Skip to content

[UI] UEFI support flag in host details #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 1 commit into from
Mar 24, 2023
Merged

[UI] UEFI support flag in host details #7361

rohityadavcloud merged 1 commit into from
Mar 24, 2023

Conversation

@harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Mar 23, 2023 •
edited
Loading

Description

This PR fixes #7356 adds the UEFI flag like below in Host details

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@harikrishna-patnala
Copy link
Contributor Author

harikrishna-patnala commented Mar 23, 2023

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 23, 2023

@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 23, 2023

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7361 (QA-JID-63)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-advanced-security
Copy link

github-advanced-security bot commented Mar 23, 2023

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #7361 (cfc2b7b) into 4.18 (74a414e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7361      +/-   ##
============================================
- Coverage     12.69%   12.68%   -0.01%     
+ Complexity     8657     8656       -1     
============================================
  Files          2717     2717              
  Lines        256143   256146       +3     
  Branches      39930    39924       -6     
============================================
- Hits          32506    32504       -2     
- Misses       219502   219508       +6     
+ Partials       4135     4134       -1
Impacted Files Coverage Δ
...ervisor/kvm/resource/LibvirtComputingResource.java 18.30% <0.00%> (ø)
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java 0.24% <0.00%> (-0.01%) ⬇️
...java/com/cloud/ovm/hypervisor/OvmResourceBase.java 0.00% <0.00%> (ø)
...oud/hypervisor/vmware/resource/VmwareResource.java 4.50% <0.00%> (-0.01%) ⬇️
...or/xenserver/resource/XenServerConnectionPool.java 9.34% <0.00%> (-0.04%) ⬇️
...java/com/cloud/alert/ConsoleProxyAlertAdapter.java 0.00% <0.00%> (ø)
...om/cloud/alert/SecondaryStorageVmAlertAdapter.java 0.00% <0.00%> (ø)
server/src/main/java/com/cloud/api/ApiServer.java 1.82% <0.00%> (-0.01%) ⬇️
...network/ExternalLoadBalancerDeviceManagerImpl.java 6.32% <0.00%> (ø)
...in/java/com/cloud/servlet/ConsoleProxyServlet.java 5.14% <0.00%> (-0.16%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland
DaanHoogland approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@rohityadavcloud rohityadavcloud added this to the 4.18.1.0 milestone Mar 24, 2023
@rohityadavcloud rohityadavcloud merged commit cfee78e into apache:4.18 Mar 24, 2023
@rohityadavcloud rohityadavcloud deleted the UEFIinHostUI branch March 24, 2023 06:35
@rohityadavcloud rohityadavcloud mentioned this pull request Mar 24, 2023
Closed
DaanHoogland added a commit that referenced this pull request Mar 29, 2023
@DaanHoogland
Merge release branch 4.18 to main
c2cffcc 
* 4.18:
  Fixed avoid set variables which is causing deployment failures (#7372)
  Add service ip to listManagementServers API response (#7374)
  UI: fix default network is not passed to deployvm API (#7367)
  ui: Added UEFI support flag in host details view (#7361)
  removed vulnerable workflow
kishankavala pushed a commit to shapeblue/cloudstack that referenced this pull request Apr 13, 2023
@harikrishna-patnala @kishankavala
ui: Added UEFI support flag in host details view (apache#7361)
799c507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@harikrishna-patnala @blueorangutan @rohityadavcloud @DaanHoogland