-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove password change notice on SSH Key Pair reset #6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove password change notice on SSH Key Pair reset #6862
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
6205534 to
43858e2
Compare
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report
@@ Coverage Diff @@
## main #6862 +/- ##
=========================================
Coverage 10.84% 10.85%
- Complexity 7105 7106 +1
=========================================
Files 2485 2485
Lines 245417 245417
Branches 38326 38326
=========================================
+ Hits 26622 26631 +9
+ Misses 215526 215517 -9
Partials 3269 3269
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ezntt , you have conflicts, can you have a look? |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
7abc7a3 to
f482139
Compare
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
Kudos, SonarCloud Quality Gate passed! |
|
UI build: ✔️ |








Description
PR #4819 removed the VM password regeneration when assigning a new SSH key pair to the VM. However, there is a message in the UI warning the user that the root's password will be changed after the reset of the SSH Key Pair. This is not the behavior anymore; therefore, part of the message is misleading the user.
This PR removes that part of the message in the UI in both language JSONs.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
I applied the changes in a local lab; then, I shut down a VM, and reset the SSH key pair of the VM. The message presented by the UI did not have the warning about the root's password changing.
I also did the tests in the other languages and they were successful.