Skip to content

Conversation

@ezntt
Copy link
Contributor

@ezntt ezntt commented Nov 1, 2022

Description

PR #4819 removed the VM password regeneration when assigning a new SSH key pair to the VM. However, there is a message in the UI warning the user that the root's password will be changed after the reset of the SSH Key Pair. This is not the behavior anymore; therefore, part of the message is misleading the user.

This PR removes that part of the message in the UI in both language JSONs.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

I applied the changes in a local lab; then, I shut down a VM, and reset the SSH key pair of the VM. The message presented by the UI did not have the warning about the root's password changing.

I also did the tests in the other languages and they were successful.

@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@ezntt ezntt force-pushed the remove-ssh-key-pair-reset-warning branch from 6205534 to 43858e2 Compare November 1, 2022 20:37
@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #6862 (6205534) into main (4c5a2ba) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6205534 differs from pull request most recent head 854d123. Consider uploading reports for the commit 854d123 to get more accurate results

@@            Coverage Diff            @@
##               main    #6862   +/-   ##
=========================================
  Coverage     10.84%   10.85%           
- Complexity     7105     7106    +1     
=========================================
  Files          2485     2485           
  Lines        245417   245417           
  Branches      38326    38326           
=========================================
+ Hits          26622    26631    +9     
+ Misses       215526   215517    -9     
  Partials       3269     3269           
Impacted Files Coverage Δ
...dstack/network/contrail/model/ModelObjectBase.java 21.15% <0.00%> (-7.70%) ⬇️
...apache/cloudstack/syslog/AlertsSyslogAppender.java 58.75% <0.00%> (+2.25%) ⬆️
...rg/apache/cloudstack/quota/QuotaStatementImpl.java 40.26% <0.00%> (+3.98%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland
Copy link
Contributor

@ezntt , you have conflicts, can you have a look?

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@ezntt ezntt force-pushed the remove-ssh-key-pair-reset-warning branch from 7abc7a3 to f482139 Compare November 8, 2022 16:51
@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6862 (LL-JID-221)

@DaanHoogland DaanHoogland merged commit 982450e into apache:main Nov 10, 2022
@ezntt ezntt deleted the remove-ssh-key-pair-reset-warning branch November 10, 2022 16:25
@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants