Skip to content

VR: add '-m <protocol>' for tcp or udp protocol #6188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvazquez merged 1 commit into from
Apr 6, 2022
Merged

VR: add '-m <protocol>' for tcp or udp protocol #6188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions systemvm/debian/opt/cloud/bin/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def add_rule(self):
" -A FIREWALL_%s" % self.ip +
" -s %s " % cidr +
" -p %s " % rule['protocol'] +
" -m %s " % rule['protocol'] +
Copy link
Contributor

@DaanHoogland DaanHoogland Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should start using format strings

Suggested change
" -m %s " % rule['protocol'] +
" -m {rule['protocol']} " +

not a biggy or in scope for this PR, just a thought on systemvm python code in general.

Copy link
Member Author

@weizhouapache weizhouapache Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. add to idea board ?

" %s -j %s" % (rnge, self.rule['action'])])

sflag = False
Expand Down