linstor-volume-plugin: Only create diskless assignments on nodes#5661
Merged
nvazquez merged 1 commit intoNov 4, 2021
Merged
Conversation
With diskful set to true, linstor will fail if it cannot create local storage for the resource. Which in turn will make it impossible to have a setup with just compute nodes on cloudstack.
Contributor
Author
|
@rhtyd It would be great if this could be included in the next RC |
yadvr
approved these changes
Nov 3, 2021
Member
|
Changes are strictly in the Linstor plugin which we don't have any means to test. We can merge this based on author/maintainers testing and smoketests from Travis and packaging pass. No need to run actual smoketests. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Member
|
@blueorangutan package |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1671 |
weizhouapache
approved these changes
Nov 3, 2021
weizhouapache
left a comment
weizhouapache
left a comment
Member
There was a problem hiding this comment.
I do not have enough knowledge to judge if this works.
but I am 100% sure this does not impact other cloudstack components ;-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With diskful set to true, linstor will fail if it cannot create local
storage for the resource. Which in turn will make it impossible to have a
setup with just compute nodes on cloudstack.
Description
This is a small bugfix that will enable to have cloudstack-agents without storage to work with Linstor volume plugin.
Before the plugin always tried to create a diskful assignment on nodes on connect, but if the node doesn't have
linstor storage, this would fail.
This was intentionally done to improve performance, as having a local disk makes write operations faster,
but there are other ways to configure diskful nodes within linstor(auto diskful, manual toggle disk).
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Local cluster setup, but the change is only within the linstor plugin, so should not have any impact on other components.