Skip to content

vmware: fix NPE for volume migration CLUSTER to ZONE-wide pool #5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 1 commit into from
Oct 17, 2021
Merged

vmware: fix NPE for volume migration CLUSTER to ZONE-wide pool #5582

rohityadavcloud merged 1 commit into from
Oct 17, 2021

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Oct 15, 2021

Description

Scope type of source pool is passed in the method, incorrectly, instead of the target pool.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested migration of a detached volume before and after fix.
Before:

2021-10-15 09:10:04,450 DEBUG [o.a.c.s.m.VmwareStorageMotionStrategy] (API-Job-Executor-1:ctx-89474df1 job-71 ctx-85827e6b) (logid:a4b3b869) class org.apache.cloudstack.storage.motion.VmwareStorageMotionStrategy can handle the request because 13(e284f229-e4b3-4095-b5e2-460ee86a3101) and 16(87d94dff-1402-4f9a-a726-5b3f5249d002) share the pod
2021-10-15 09:10:04,453 ERROR [o.a.c.s.v.VolumeServiceImpl] (API-Job-Executor-1:ctx-89474df1 job-71 ctx-85827e6b) (logid:a4b3b869) Failed to copy volume:java.lang.NullPointerException
2021-10-15 09:10:04,453 DEBUG [o.a.c.s.v.VolumeServiceImpl] (API-Job-Executor-1:ctx-89474df1 job-71 ctx-85827e6b) (logid:a4b3b869) Failed to copy volume.
java.lang.NullPointerException
	at org.apache.cloudstack.storage.motion.VmwareStorageMotionStrategy.getHostGuidInTargetCluster(VmwareStorageMotionStrategy.java:143)
	at org.apache.cloudstack.storage.motion.VmwareStorageMotionStrategy.getHostIdForVmAndHostGuidInTargetClusterForWorkerVm(VmwareStorageMotionStrategy.java:184)
	at org.apache.cloudstack.storage.motion.VmwareStorageMotionStrategy.getHostIdForVmAndHostGuidInTargetCluster(VmwareStorageMotionStrategy.java:204)
	at org.apache.cloudstack.storage.motion.VmwareStorageMotionStrategy.copyAsync(VmwareStorageMotionStrategy.java:245)
	at org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:84)
	at org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:106)

After: migration successful

@shwstppr
vmware: fix NPE for volume migration CLUSTER to ZONE-wide pool
dbbe97d 
Scope type of source pool is passed in the method, incorrectly, instead of the target pool.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 15, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 15, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 15, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1574

@rohityadavcloud rohityadavcloud added this to the 4.16.0.0 milestone Oct 15, 2021
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Oct 15, 2021

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

blueorangutan commented Oct 15, 2021

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 15, 2021

Trillian Build Failed (tid-2423)

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Oct 15, 2021

@blueorangutan package

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Oct 15, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 15, 2021

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 15, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1578

@nvazquez
Copy link
Contributor

nvazquez commented Oct 16, 2021

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

blueorangutan commented Oct 16, 2021

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@nvazquez
Copy link
Contributor

nvazquez commented Oct 16, 2021

@blueorangutan test matrix

@blueorangutan
Copy link

blueorangutan commented Oct 16, 2021

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 16, 2021

Trillian test result (tid-2427)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30881 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5582-t2427-kvm-centos7.zip
Smoke tests completed. 87 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

blueorangutan commented Oct 16, 2021

Trillian test result (tid-2426)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33121 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5582-t2426-xenserver-71.zip
Smoke tests completed. 87 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

blueorangutan commented Oct 17, 2021

Trillian test result (tid-2428)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34150 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5582-t2428-vmware-65u2.zip
Smoke tests completed. 87 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@rohityadavcloud rohityadavcloud merged commit 330e8e6 into apache:4.15 Oct 17, 2021
rohityadavcloud added a commit that referenced this pull request Oct 17, 2021
@rohityadavcloud
Merge pull request #5583 from apache/4.15
a8b19ee 
vmware: fix NPE for volume migration CLUSTER to ZONE-wide pool (#5582)
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@shwstppr @rohityadavcloud
vmware: fix NPE for volume migration CLUSTER to ZONE-wide pool (apach…
a8ea889 
…e#5582)

Scope type of source pool is passed in the method, incorrectly, instead of the target pool.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
(cherry picked from commit 330e8e6)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@shwstppr @rohityadavcloud
vmware: fix NPE for volume migration CLUSTER to ZONE-wide pool (apach…
f9ca968 
…e#5582)

Scope type of source pool is passed in the method, incorrectly, instead of the target pool.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
(cherry picked from commit 330e8e6)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees

No one assigned

Labels

component:migration component:vmware Severity:Critical Critical bug

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shwstppr @blueorangutan @rohityadavcloud @nvazquez