Skip to content

Updated storage type of the volume, in the volume response, based on the underlying storage pool #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvazquez merged 1 commit into from
Oct 10, 2021
Merged

Updated storage type of the volume, in the volume response, based on the underlying storage pool #5560

nvazquez merged 1 commit into from
Oct 10, 2021

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Oct 8, 2021

Description

This PR updates the storage type of the volume, in the volume response, based on the underlying storage pool.

Fixes: #5558

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

ROOT disk =>

ROOTDisk_Shared

DATA disk =>

DATADisk_Local

How Has This Been Tested?

  • Manually tested the storage pool types for migrated volumes from Local to Shared storage, and vice versa.

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Oct 8, 2021

@blueorangutan package

@nvazquez nvazquez added this to the 4.16.0.0 milestone Oct 8, 2021
nvazquez
nvazquez approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Oct 8, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 8, 2021

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 8, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1534

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Oct 8, 2021

@blueorangutan test matrix

@blueorangutan
Copy link

blueorangutan commented Oct 8, 2021

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

Trillian test result (tid-2362)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33662 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5560-t2362-kvm-centos7.zip
Smoke tests completed. 86 look OK, 5 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_primary_storage_disabled_host Error 0.66 test_primary_storage.py
test_01_primary_storage_nfs Error 0.13 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.22 test_primary_storage.py
test_01_secure_vm_migration Error 165.95 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 275.58 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 148.32 test_vm_life_cycle.py
test_08_migrate_vm Error 45.89 test_vm_life_cycle.py
test_03_deploy_and_scale_kubernetes_cluster Failure 32.96 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 67.70 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 44.20 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 43.12 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 133.19 test_kubernetes_clusters.py
test_02_list_snapshots_with_removed_data_store Error 8.56 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 8.56 test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance Error 304.88 test_hostha_kvm.py

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

Trillian test result (tid-2361)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35588 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5560-t2361-xenserver-71.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

Trillian test result (tid-2363)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38039 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5560-t2363-vmware-65u2.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_create_pvlan_network Error 0.04 test_pvlan.py

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Oct 9, 2021

@blueorangutan test matrix

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

Trillian Build Failed (tid-2365)

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

Trillian Build Failed (tid-2366)

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Oct 9, 2021

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 9, 2021

Trillian test result (tid-2367)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34238 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5560-t2367-vmware-65u2.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@nvazquez nvazquez merged commit 07efd7c into apache:main Oct 10, 2021
@blueorangutan
Copy link

blueorangutan commented Oct 10, 2021

Trillian test result (tid-2371)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 107558 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5560-t2371-kvm-centos7.zip
Smoke tests completed. 62 look OK, 29 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestRemoteDiagnostics>:setup Error 0.00 test_diagnostics.py
ContextSuite context=TestLoadBalance>:setup Error 0.00 test_loadbalance.py
ContextSuite context=TestVPCRedundancy>:setup Error 0.00 test_vpc_redundant.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup Error 0.00 test_password_server.py
ContextSuite context=TestDeployVMFromISO>:setup Error 0.00 test_deploy_vm_iso.py
ContextSuite context=TestRouterDHCPHosts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestResetVmOnReboot>:setup Error 0.00 test_reset_vm_on_reboot.py
ContextSuite context=TestDeployVmWithUserData>:setup Error 0.00 test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup Error 0.00 test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup Error 0.00 test_resource_accounting.py
ContextSuite context=TestPortForwardingRules>:setup Error 0.00 test_portforwardingrules.py
ContextSuite context=TestDomainsServiceOfferings>:setup Error 1515.27 test_domain_service_offerings.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_01_template_usage Error 18.58 test_usage.py
test_01_volume_usage Error 186.87 test_usage.py
test_list_clusters_metrics Error 1512.30 test_metrics_api.py
test_list_vms_metrics Error 0.16 test_metrics_api.py
ContextSuite context=TestRouterDns>:setup Error 0.00 test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup Error 0.00 test_router_dnsservice.py
ContextSuite context=TestRouterServices>:setup Error 0.00 test_routers.py
ContextSuite context=TestIsolatedNetworks>:setup Error 0.00 test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup Error 0.00 test_routers_network_ops.py
test_01_invalid_upgrade_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.01 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.01 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.01 test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version Error 1802.45 test_kubernetes_supported_versions.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup Error 0.13 test_service_offerings.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
test_delete_account Error 1512.08 test_network.py
test_delete_network_while_vm_on_it Error 1.13 test_network.py
test_deploy_vm_l2network Error 1.13 test_network.py
test_l2network_restart Error 2.20 test_network.py
ContextSuite context=TestPortForwarding>:setup Error 3.37 test_network.py
ContextSuite context=TestPublicIP>:setup Error 1.17 test_network.py
test_reboot_router Failure 0.05 test_network.py
test_releaseIP Error 0.49 test_network.py
ContextSuite context=TestRouterRules>:setup Error 0.55 test_network.py
ContextSuite context=TestNetworkACL>:setup Error 0.00 test_network_acl.py
ContextSuite context=TestSnapshotRootDisk>:setup Error 0.00 test_snapshots.py
ContextSuite context=TestAdapterTypeForNic>:setup Error 0.00 test_nic_adapter_type.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@nvazquez nvazquez nvazquez approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@GabrielBrascher GabrielBrascher Awaiting requested review from GabrielBrascher

Assignees

No one assigned

Labels

component:api type:bug

Projects

None yet

Milestone

4.16.0.0

4 participants

@sureshanaparti @blueorangutan @rohityadavcloud @nvazquez