Skip to content

ui: Replace bulk delete icons #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DaanHoogland merged 1 commit into from
Jul 21, 2021
Merged

ui: Replace bulk delete icons #5222

DaanHoogland merged 1 commit into from
Jul 21, 2021

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Jul 20, 2021

Description

Uses the appropriate icon for delete

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Amongst others :
Screenshot from 2021-07-20 11-07-50

@davidjumani
Copy link
Contributor Author

davidjumani commented Jul 20, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@davidjumani davidjumani added this to the 4.16.0.0 milestone Jul 20, 2021
@davidjumani
Copy link
Contributor Author

davidjumani commented Jul 20, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5222 (SL-JID-397)

@davidjumani davidjumani requested a review from utchoang July 21, 2021 05:07
utchoang
utchoang approved these changes Jul 21, 2021
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaanHoogland DaanHoogland merged commit 61de489 into apache:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidjumani @blueorangutan @DaanHoogland @utchoang