ui: Refresh after async job completed only on current / parent page #5214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjumani
changed the title
Contributor
1 similar comment
Contributor
Author
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
davidjumani
force-pushed
the
fix-async-refresh
branch
from
b03ba1e to
b168a46
Compare
|
UI build: ✔️ |
davidjumani
force-pushed
the
fix-async-refresh
branch
from
b168a46 to
f9dfec4
Compare
Contributor
Author
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Jul 21, 2021
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, but not sure what eventBus.$emit('async-job-complete') does except for redrawing a page. quick monkey test succeeded but like to play more than just the simplest scenario.
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 613 |
Contributor
|
tested with stop/start/delete/recover VM all good merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5172
Ensures that the page is refreshed after an async job only if it is the same / parent page being viewed
Types of changes
Bug Severity