Skip to content

Fix deprecation of CIDR_LIST parameter #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 3 commits into from
Jul 16, 2021
Merged

Fix deprecation of CIDR_LIST parameter #5211

rohityadavcloud merged 3 commits into from
Jul 16, 2021
+3 −3

Conversation

@onitake
Copy link
Contributor

@onitake onitake commented Jul 15, 2021

Description

This is a follow-up to #4037 .

The CIDR_LIST parameter was only deprecated for CreateIpForwardingRule, CreateLoadBalancerRule and CreatePortForwardingRule. It is still supported for CreateFirewallRule.

This PR documents the deprecation in all these API calls, and reverts the deprecation for CreateFirewallRule.

@weizhouapache

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

N/A

@weizhouapache
Copy link
Member

weizhouapache commented Jul 15, 2021

@onitake good, thanks for the fix.

@nvazquez code lgtm

@weizhouapache
Copy link
Member

weizhouapache commented Jul 15, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 15, 2021

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 15, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 559

@weizhouapache
Copy link
Member

weizhouapache commented Jul 15, 2021

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jul 15, 2021

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez
nvazquez approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez closed this Jul 15, 2021
@nvazquez nvazquez reopened this Jul 15, 2021
@blueorangutan
Copy link

blueorangutan commented Jul 16, 2021

Trillian test result (tid-1283)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37780 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5211-t1283-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@nvazquez nvazquez closed this Jul 16, 2021
@nvazquez nvazquez reopened this Jul 16, 2021
@rohityadavcloud rohityadavcloud added this to the 4.16.0.0 milestone Jul 16, 2021
@rohityadavcloud rohityadavcloud merged commit ff07fee into apache:main Jul 16, 2021
@onitake onitake deleted the doc/deprecate-lb-fwd-rule-undeprecate-fw-rule branch July 17, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

Severity:Trivial type:cleanup

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@onitake @weizhouapache @blueorangutan @nvazquez @rohityadavcloud @srgoni