Skip to content

UI: deploy VM - FIX missing custom iops field #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 8 commits into from
Jul 15, 2021
Merged

UI: deploy VM - FIX missing custom iops field #5199

rohityadavcloud merged 8 commits into from
Jul 15, 2021

Conversation

@utchoang
Copy link

@utchoang utchoang commented Jul 12, 2021

Description

Fixes #5192

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@utchoang utchoang changed the base branch from main to 4.15 July 12, 2021 02:40
@utchoang utchoang requested a review from shwstppr July 12, 2021 02:41
@utchoang utchoang closed this Jul 12, 2021
@utchoang utchoang reopened this Jul 12, 2021
@utchoang
Copy link
Author

utchoang commented Jul 12, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5199 (SL-JID-343)

@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Jul 12, 2021

@utchoang thanks for working on the fix.

I've checked on the QA env above and also on my local environment I don't see the new changes coming up on UI. Can you please quickly check that. I did not debug much in the code apart from testing the PR.

I've tried to check to create a data disk directly and through the deploy VM wizard, but did not see the UI changes.

@utchoang
Copy link
Author

utchoang commented Jul 12, 2021

@harikrishna-patnala I tested on QA and it shows up, can you check again?
image

@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Jul 12, 2021

I tried different browsers and different system too, but not seeing this.
image

@shwstppr
Copy link
Contributor

shwstppr commented Jul 12, 2021

Visible now @harikrishna-patnala?
Screenshot from 2021-07-12 11-05-55

@utchoang
Copy link
Author

utchoang commented Jul 12, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5199 (SL-JID-344)

@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Jul 12, 2021

with new build I can see the changes @utchoang, thanks.

I found few more things to fix, can you please look into them.

  1. Disk offering with custom IOPS only (with disk size specified in disk offering) is not listing IOPS fields in deploy VM wizard
    image

  2. "Create Volume" needs a complete fix I think
    image

@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Jul 12, 2021

just noticed, we need to add custom IOPS flag in the UI response

image

@utchoang
Copy link
Author

utchoang commented Jul 12, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5199 (SL-JID-345)

@utchoang
Copy link
Author

utchoang commented Jul 12, 2021

@harikrishna-patnala Please check again? Thanks.
image
image

@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Jul 12, 2021

Thanks @utchoang for doing all the changes.

I did further testing and deployed VM with disk offering having custom IOPS and observed the parameter that are set.
"details[0].minIops=1&details[0].maxIops=2"

  1. In case of data disk, the IOPS values should go into "minIopsDo" and "maxIopsDo"
  2. In case of VM deployed from ISO or if the values are meant for root disk then these have to go in "minIops" and "minIops"

@utchoang
Copy link
Author

utchoang commented Jul 12, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5199 (SL-JID-347)

harikrishna-patnala
harikrishna-patnala approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested custom IOPS UI changes and APIs. LGTM.

@rohityadavcloud rohityadavcloud added this to the 4.15.2.0 milestone Jul 15, 2021
rohityadavcloud
rohityadavcloud approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on Hari's review/testing

@rohityadavcloud rohityadavcloud merged commit 7123269 into apache:4.15 Jul 15, 2021
@rohityadavcloud rohityadavcloud mentioned this pull request Jul 15, 2021
Closed
@utchoang utchoang deleted the feature/vm-custom-iops-field branch July 15, 2021 07:35
@nvazquez nvazquez mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.15.2.0

Development

Successfully merging this pull request may close these issues.

[UI] Missing custom IOPS fields in deploy instance wizard

5 participants

@utchoang @blueorangutan @harikrishna-patnala @shwstppr @rohityadavcloud