Skip to content

UI: fix NIC table on instance view #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 1 commit into from
Jul 15, 2021
Merged

UI: fix NIC table on instance view #5197

rohityadavcloud merged 1 commit into from
Jul 15, 2021

Conversation

@mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jul 11, 2021 •
edited
Loading

Description

This PR fixes a small UI bug, where a-descriptions is used by NicsTable but component is not registered properly, so UI looks bad and erros were thrown in debug console:

[Vue warn]: Unknown custom element: <a-descriptions> - did you register the component correctly? For recursive components, make sure to provide the "name" option.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot prior this change:
grafik

Screenshot with this change:
grafik

How Has This Been Tested?

Local with CS simulator

@mib1185
Copy link
Contributor Author

mib1185 commented Jul 11, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

@mib1185 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@mib1185
Copy link
Contributor Author

mib1185 commented Jul 11, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

@mib1185 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5197 (SL-JID-340)

@mib1185
Copy link
Contributor Author

mib1185 commented Jul 11, 2021

@blueorangutan thanks

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

you're welcome @mib1185

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 515

@mib1185 mib1185 changed the title UI: register vue component Descriptions UI: fix NIC table on instance view Jul 11, 2021
utchoang
utchoang approved these changes Jul 12, 2021
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @mib1185

Pearl1594
Pearl1594 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwstppr
Copy link
Contributor

shwstppr commented Jul 12, 2021

@mib1185 good to have in 4.15 branch?

@mib1185
Copy link
Contributor Author

mib1185 commented Jul 12, 2021 •
edited
Loading

@shwstppr yeah sure, it is a quiet small fix 🙂
ah ... now I see .... need to rebase to 4.15 and change target branch for this PR

@mib1185 mib1185 force-pushed the fix/register-vue-component-descriptions branch from 9d8cdf5 to 317d6cc Compare July 12, 2021 07:08
@mib1185 mib1185 changed the base branch from main to 4.15 July 12, 2021 07:09
@mib1185
Copy link
Contributor Author

mib1185 commented Jul 12, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

@mib1185 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 12, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5197 (SL-JID-346)

@rohityadavcloud rohityadavcloud added this to the 4.15.2.0 milestone Jul 15, 2021
@rohityadavcloud rohityadavcloud merged commit 6b5adb7 into apache:4.15 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@davidjumani davidjumani davidjumani approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.15.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@mib1185 @blueorangutan @shwstppr @davidjumani @Pearl1594 @utchoang @rohityadavcloud