server: fix network access for addNicToVirtualMachine API #5184

shwstppr · 2021-07-05T13:30:07Z

Description

New NICs shouldn't be added to VM with Shared and Isolated networks from admin account, same as deployment.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested:

Admin trying to add a network from its own account to a VM from a user account.
Admin trying to deploy VM in a user account with a network from its own account.
Admin trying to attach a volume from its own account to a VM from a user account.

Networks

(local) 🐧 > list networks filter=id,name,domain,account listall=true 
{
  "count": 3,
  "network": [
    {
      "account": "admin",
      "domain": "ROOT",
      "id": "06fbdecb-e75d-4015-9ec1-8a08a217ad2d",
      "name": "l2nw"
    },
    {
      "account": "admin",
      "domain": "ROOT",
      "id": "a99496df-aade-42d7-b315-33f69719cdd6",
      "name": "isonw"
    },
    {
      "account": "user1",
      "domain": "ROOT",
      "id": "2b56b153-9b56-4cf0-b23a-ef3817f9b806",
      "name": "nw"
    }
  ]
}

Current behaviour for NIC/networks (works for all networks):

(local) 🕷 > list virtualmachines id=08a416c6-86c6-4e41-9263-8d1f386d85b2 filter=id,name,domain,account,nic
{
  "count": 1,
  "virtualmachine": [
    {
      "account": "user1",
      "domain": "ROOT",
      "id": "08a416c6-86c6-4e41-9263-8d1f386d85b2",
      "name": "QA-08a416c6-86c6-4e41-9263-8d1f386d85b2",
      "nic": [
        {
          "broadcasturi": "vlan://144",
          "extradhcpoption": [],
          "gateway": "10.1.1.1",
          "id": "61dbd058-04f8-4a3c-b2c9-1ad91ef2b15f",
          "ipaddress": "10.1.1.38",
          "isdefault": true,
          "isolationuri": "vlan://144",
          "macaddress": "02:00:68:3a:00:09",
          "netmask": "255.255.255.0",
          "networkid": "2b56b153-9b56-4cf0-b23a-ef3817f9b806",
          "networkname": "nw",
          "secondaryip": [],
          "traffictype": "Guest",
          "type": "Isolated"
        }
      ]
    }
  ]
}
(local) 🐄 > add nictovirtualmachine virtualmachineid=08a416c6-86c6-4e41-9263-8d1f386d85b2 networkid=a99496df-aade-42d7-b315-33f69719cdd6 
{
  "virtualmachine": {
    "account": "user1",
    "affinitygroup": [],
    "bootmode": "legacy",
    "boottype": "Bios",
    "created": "2021-07-06T13:33:29+0530",
    "details": {},
    "displayname": "QA-08a416c6-86c6-4e41-9263-8d1f386d85b2",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "8d26be19-de24-11eb-9f57-645d8651f45a",
    "guestosid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "haenable": false,
    "hostid": "4ee25548-beba-4919-b3dc-fa17ccda787f",
    "hostname": "SimulatedAgent.822e30ca-1fcf-4907-b01c-fd4df43c8b78",
    "hypervisor": "Simulator",
    "id": "08a416c6-86c6-4e41-9263-8d1f386d85b2",
    "instancename": "i-5-12-QA",
    "isdynamicallyscalable": false,
    "name": "QA-08a416c6-86c6-4e41-9263-8d1f386d85b2",
    "nic": [
      {
        "broadcasturi": "vlan://144",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "61dbd058-04f8-4a3c-b2c9-1ad91ef2b15f",
        "ipaddress": "10.1.1.38",
        "isdefault": true,
        "isolationuri": "vlan://144",
        "macaddress": "02:00:68:3a:00:09",
        "netmask": "255.255.255.0",
        "networkid": "2b56b153-9b56-4cf0-b23a-ef3817f9b806",
        "networkname": "nw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      },
      {
        "broadcasturi": "vlan://165",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "809818df-f27d-4093-bce8-d5090f71be09",
        "ipaddress": "10.1.1.21",
        "isdefault": false,
        "isolationuri": "vlan://165",
        "macaddress": "02:00:6f:43:00:03",
        "netmask": "255.255.255.0",
        "networkid": "a99496df-aade-42d7-b315-33f69719cdd6",
        "networkname": "isonw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "CentOS 5.6 (64-bit)",
    "ostypeid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "pooltype": "NetworkFilesystem",
    "securitygroup": [],
    "state": "Running",
    "tags": [],
    "userid": "373a6269-44f3-4853-8462-1f84cd3261db",
    "username": "user1",
    "zoneid": "f058985d-64b4-4cb9-8185-12ccb3e36e6b",
    "zonename": "Sandbox-simulator"
  }
}
(local) 🙉 > add nictovirtualmachine virtualmachineid=08a416c6-86c6-4e41-9263-8d1f386d85b2 networkid=06fbdecb-e75d-4015-9ec1-8a08a217ad2d 
{
  "virtualmachine": {
    "account": "user1",
    "affinitygroup": [],
    "bootmode": "legacy",
    "boottype": "Bios",
    "created": "2021-07-06T13:33:29+0530",
    "details": {},
    "displayname": "QA-08a416c6-86c6-4e41-9263-8d1f386d85b2",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "8d26be19-de24-11eb-9f57-645d8651f45a",
    "guestosid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "haenable": false,
    "hostid": "4ee25548-beba-4919-b3dc-fa17ccda787f",
    "hostname": "SimulatedAgent.822e30ca-1fcf-4907-b01c-fd4df43c8b78",
    "hypervisor": "Simulator",
    "id": "08a416c6-86c6-4e41-9263-8d1f386d85b2",
    "instancename": "i-5-12-QA",
    "isdynamicallyscalable": false,
    "name": "QA-08a416c6-86c6-4e41-9263-8d1f386d85b2",
    "nic": [
      {
        "broadcasturi": "vlan://146",
        "extradhcpoption": [],
        "id": "207f8554-5f76-42a2-908b-8a2d9a91b3b7",
        "isdefault": false,
        "isolationuri": "vlan://146",
        "macaddress": "02:00:19:f9:00:02",
        "networkid": "06fbdecb-e75d-4015-9ec1-8a08a217ad2d",
        "networkname": "l2nw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "L2"
      },
      {
        "broadcasturi": "vlan://144",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "61dbd058-04f8-4a3c-b2c9-1ad91ef2b15f",
        "ipaddress": "10.1.1.38",
        "isdefault": true,
        "isolationuri": "vlan://144",
        "macaddress": "02:00:68:3a:00:09",
        "netmask": "255.255.255.0",
        "networkid": "2b56b153-9b56-4cf0-b23a-ef3817f9b806",
        "networkname": "nw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      },
      {
        "broadcasturi": "vlan://165",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "809818df-f27d-4093-bce8-d5090f71be09",
        "ipaddress": "10.1.1.21",
        "isdefault": false,
        "isolationuri": "vlan://165",
        "macaddress": "02:00:6f:43:00:03",
        "netmask": "255.255.255.0",
        "networkid": "a99496df-aade-42d7-b315-33f69719cdd6",
        "networkname": "isonw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "CentOS 5.6 (64-bit)",
    "ostypeid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "pooltype": "NetworkFilesystem",
    "securitygroup": [],
    "state": "Running",
    "tags": [],
    "userid": "373a6269-44f3-4853-8462-1f84cd3261db",
    "username": "user1",
    "zoneid": "f058985d-64b4-4cb9-8185-12ccb3e36e6b",
    "zonename": "Sandbox-simulator"
  }
}

Current deployment behaviour (works for L2 network, fails for Isolated and Shared networks)

(local) 🐼 > deploy virtualmachine zoneid=f058985d-64b4-4cb9-8185-12ccb3e36e6b templateid=92b2849b-de25-11eb-9f57-645d8651f45a serviceofferingid=2da9fd13-5eb3-44a2-8912-656ab3facb9d domainid=8d26be19-de24-11eb-9f57-645d8651f45a account=user1 networkids=06fbdecb-e75d-4015-9ec1-8a08a217ad2d 
{
  "virtualmachine": {
    "account": "user1",
    "affinitygroup": [],
    "bootmode": "legacy",
    "boottype": "Bios",
    "cpunumber": 1,
    "cpuspeed": 500,
    "created": "2021-07-06T13:53:52+0530",
    "details": {},
    "displayname": "QA-ed28c0f9-7e90-4199-8deb-8689c34f0cb2",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "8d26be19-de24-11eb-9f57-645d8651f45a",
    "guestosid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "haenable": false,
    "hostid": "192509ea-0b6c-4267-902e-9be337061f13",
    "hostname": "SimulatedAgent.77b0247e-3448-41ce-9c07-5054cbc3a90c",
    "hypervisor": "Simulator",
    "id": "ed28c0f9-7e90-4199-8deb-8689c34f0cb2",
    "instancename": "i-5-17-QA",
    "isdynamicallyscalable": false,
    "jobid": "a859c500-40d5-44ee-94b6-4a3046f280e3",
    "jobstatus": 0,
    "memory": 512,
    "name": "QA-ed28c0f9-7e90-4199-8deb-8689c34f0cb2",
    "nic": [
      {
        "broadcasturi": "vlan://146",
        "extradhcpoption": [],
        "id": "f7c77fb7-6c80-4aec-9a6f-1a761dc9b136",
        "isdefault": true,
        "isolationuri": "vlan://146",
        "macaddress": "02:00:59:31:00:04",
        "networkid": "06fbdecb-e75d-4015-9ec1-8a08a217ad2d",
        "networkname": "l2nw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "L2"
      }
    ],
    "osdisplayname": "CentOS 5.6 (64-bit)",
    "ostypeid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "serviceofferingid": "2da9fd13-5eb3-44a2-8912-656ab3facb9d",
    "serviceofferingname": "Small Instance",
    "state": "Running",
    "tags": [],
    "templatedisplaytext": "CentOS 5.6 (64-bit) no GUI (Simulator)",
    "templateid": "92b2849b-de25-11eb-9f57-645d8651f45a",
    "templatename": "CentOS 5.6 (64-bit) no GUI (Simulator)",
    "userid": "373a6269-44f3-4853-8462-1f84cd3261db",
    "username": "user1",
    "zoneid": "f058985d-64b4-4cb9-8185-12ccb3e36e6b",
    "zonename": "Sandbox-simulator"
  }
}
(local) 🦑 > deploy virtualmachine zoneid=f058985d-64b4-4cb9-8185-12ccb3e36e6b templateid=92b2849b-de25-11eb-9f57-645d8651f45a serviceofferingid=2da9fd13-5eb3-44a2-8912-656ab3facb9d domainid=8d26be19-de24-11eb-9f57-645d8651f45a account=user1 networkids=a99496df-aade-42d7-b315-33f69719cdd6 
🙈 Error: (HTTP 531, error code 4365) Unable to use network with id= a99496df-aade-42d7-b315-33f69719cdd6, permission denied

Current attach data disk behaviour (fails)

(local) 🐯 > create volume zoneid=f058985d-64b4-4cb9-8185-12ccb3e36e6b diskofferingid=355c7a9b-9605-4ada-9122-3b0511a46220 name=newdd
{
  "volume": {
    "account": "admin",
    "created": "2021-07-06T14:00:37+0530",
    "destroyed": false,
    "diskofferingdisplaytext": "Small Disk, 5 GB",
    "diskofferingid": "355c7a9b-9605-4ada-9122-3b0511a46220",
    "diskofferingname": "Small",
    "displayvolume": true,
    "domain": "ROOT",
    "domainid": "8d26be19-de24-11eb-9f57-645d8651f45a",
    "hypervisor": "None",
    "id": "355ca00d-3857-46e4-a3ff-e4e935a09ffa",
    "isextractable": true,
    "jobid": "adcb8af3-adcb-41b9-8c2d-14d8c8c5fcde",
    "jobstatus": 0,
    "name": "newdd",
    "provisioningtype": "thin",
    "quiescevm": false,
    "size": 5368709120,
    "state": "Allocated",
    "storagetype": "shared",
    "supportsstoragesnapshot": false,
    "tags": [],
    "type": "DATADISK",
    "zoneid": "f058985d-64b4-4cb9-8185-12ccb3e36e6b",
    "zonename": "Sandbox-simulator"
  }
}
(local) 🦏 > attach volume id=355ca00d-3857-46e4-a3ff-e4e935a09ffa virtualmachineid=08a416c6-86c6-4e41-9263-8d1f386d85b2 
{
  "accountid": "8d26fee1-de24-11eb-9f57-645d8651f45a",
  "cmd": "org.apache.cloudstack.api.command.admin.volume.AttachVolumeCmdByAdmin",
  "completed": "2021-07-06T14:01:16+0530",
  "created": "2021-07-06T14:01:16+0530",
  "jobid": "7bf73ed7-c890-41e7-bd63-9422e5370db1",
  "jobinstanceid": "355ca00d-3857-46e4-a3ff-e4e935a09ffa",
  "jobinstancetype": "Volume",
  "jobprocstatus": 0,
  "jobresult": {
    "errorcode": 530,
    "errortext": "Entity VM instance {\"id\": \"12\", \"name\": \"i-5-12-QA\", \"uuid\": \"08a416c6-86c6-4e41-9263-8d1f386d85b2\", \"type\"=\"User\"} and entity org.apache.cloudstack.storage.volume.VolumeObject@2d7250bf belong to different accounts"
  },
  "jobresultcode": 530,
  "jobresulttype": "object",
  "jobstatus": 2,
  "userid": "8d276e01-de24-11eb-9f57-645d8651f45a"
}
🙈 Error: async API failed for job 7bf73ed7-c890-41e7-bd63-9422e5370db1

After changes add NIC/network behaviour (fails for Isolated and shared networks but works for L2 networks)

(local) 🐺 > list virtualmachines id=0bd71bc7-80b4-4214-8967-3b925382ef63 filter=id,name,domain,account,nic
{
  "count": 1,
  "virtualmachine": [
    {
      "account": "user1",
      "domain": "ROOT",
      "id": "0bd71bc7-80b4-4214-8967-3b925382ef63",
      "name": "QA-0bd71bc7-80b4-4214-8967-3b925382ef63",
      "nic": [
        {
          "broadcasturi": "vlan://144",
          "extradhcpoption": [],
          "gateway": "10.1.1.1",
          "id": "f56ba6d1-1516-43c9-9a4c-1535a9d449e4",
          "ipaddress": "10.1.1.219",
          "isdefault": true,
          "isolationuri": "vlan://144",
          "macaddress": "02:00:01:ed:00:0a",
          "netmask": "255.255.255.0",
          "networkid": "2b56b153-9b56-4cf0-b23a-ef3817f9b806",
          "networkname": "nw",
          "secondaryip": [],
          "traffictype": "Guest",
          "type": "Isolated"
        }
      ]
    }
  ]
}
(local) 🐕 > add nictovirtualmachine virtualmachineid=0bd71bc7-80b4-4214-8967-3b925382ef63 networkid=a99496df-aade-42d7-b315-33f69719cdd6 
{
  "accountid": "8d26fee1-de24-11eb-9f57-645d8651f45a",
  "cmd": "org.apache.cloudstack.api.command.admin.vm.AddNicToVMCmdByAdmin",
  "completed": "2021-07-06T13:52:24+0530",
  "created": "2021-07-06T13:52:24+0530",
  "jobid": "dc801e6b-f3df-474a-b173-fac91c869202",
  "jobprocstatus": 0,
  "jobresult": {
    "errorcode": 530,
    "errortext": "Unable to use network with id= a99496df-aade-42d7-b315-33f69719cdd6, permission denied"
  },
  "jobresultcode": 530,
  "jobresulttype": "object",
  "jobstatus": 2,
  "userid": "8d276e01-de24-11eb-9f57-645d8651f45a"
}
🙈 Error: async API failed for job dc801e6b-f3df-474a-b173-fac91c869202
(local) 🦉 > add nictovirtualmachine virtualmachineid=0bd71bc7-80b4-4214-8967-3b925382ef63 networkid=06fbdecb-e75d-4015-9ec1-8a08a217ad2d 
{
  "virtualmachine": {
    "account": "user1",
    "affinitygroup": [],
    "bootmode": "legacy",
    "boottype": "Bios",
    "created": "2021-07-06T13:33:31+0530",
    "details": {},
    "displayname": "QA-0bd71bc7-80b4-4214-8967-3b925382ef63",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "8d26be19-de24-11eb-9f57-645d8651f45a",
    "guestosid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "haenable": false,
    "hostid": "192509ea-0b6c-4267-902e-9be337061f13",
    "hostname": "SimulatedAgent.77b0247e-3448-41ce-9c07-5054cbc3a90c",
    "hypervisor": "Simulator",
    "id": "0bd71bc7-80b4-4214-8967-3b925382ef63",
    "instancename": "i-5-13-QA",
    "isdynamicallyscalable": false,
    "name": "QA-0bd71bc7-80b4-4214-8967-3b925382ef63",
    "nic": [
      {
        "broadcasturi": "vlan://146",
        "extradhcpoption": [],
        "id": "280e89c8-4c38-4750-a5a2-e9c80860d99b",
        "isdefault": false,
        "isolationuri": "vlan://146",
        "macaddress": "02:00:10:8f:00:03",
        "networkid": "06fbdecb-e75d-4015-9ec1-8a08a217ad2d",
        "networkname": "l2nw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "L2"
      },
      {
        "broadcasturi": "vlan://144",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "f56ba6d1-1516-43c9-9a4c-1535a9d449e4",
        "ipaddress": "10.1.1.219",
        "isdefault": true,
        "isolationuri": "vlan://144",
        "macaddress": "02:00:01:ed:00:0a",
        "netmask": "255.255.255.0",
        "networkid": "2b56b153-9b56-4cf0-b23a-ef3817f9b806",
        "networkname": "nw",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "CentOS 5.6 (64-bit)",
    "ostypeid": "8d148fc5-de24-11eb-9f57-645d8651f45a",
    "pooltype": "NetworkFilesystem",
    "securitygroup": [],
    "state": "Running",
    "tags": [],
    "userid": "373a6269-44f3-4853-8462-1f84cd3261db",
    "username": "user1",
    "zoneid": "f058985d-64b4-4cb9-8185-12ccb3e36e6b",
    "zonename": "Sandbox-simulator"
  }
}

weizhouapache

code lgtm

weizhouapache · 2021-07-06T12:44:42Z

@shwstppr re-target to 4.15 ?

New NICs shouldn't added to VM with network from admin account, same as deployment. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-07-06T13:07:20Z

@weizhouapache done

@blueorangutan package

blueorangutan · 2021-07-06T13:08:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-07-06T13:32:58Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 481

shwstppr · 2021-07-06T13:48:14Z

@blueorangutan test

blueorangutan · 2021-07-06T13:49:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-07-06T23:33:10Z

Trillian test result (tid-1210)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33430 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5184-t1210-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Pearl1594

LGTM. verified behavior - add NIC to VM behaviour aligns with deployment workflow

shwstppr marked this pull request as ready for review July 6, 2021 11:44

shwstppr closed this Jul 6, 2021

shwstppr reopened this Jul 6, 2021

weizhouapache approved these changes Jul 6, 2021

View reviewed changes

shwstppr changed the base branch from main to 4.15 July 6, 2021 13:00

server: fix network access for addNicToVirtualMachine API

e12a7e9

New NICs shouldn't added to VM with network from admin account, same as deployment. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr force-pushed the fix-addnictovm-networkperm branch from e4831ff to e12a7e9 Compare July 6, 2021 13:04

apache deleted a comment from blueorangutan Jul 6, 2021

shwstppr requested review from GabrielBrascher, Pearl1594, andrijapanicsb and rohityadavcloud July 7, 2021 10:56

DaanHoogland added this to the 4.15.2.0 milestone Jul 13, 2021

Pearl1594 approved these changes Jul 15, 2021

View reviewed changes

rohityadavcloud merged commit e0141ab into apache:4.15 Jul 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

server: fix network access for addNicToVirtualMachine API #5184

server: fix network access for addNicToVirtualMachine API #5184

Uh oh!

shwstppr commented Jul 5, 2021 •

edited by weizhouapache

Loading

Uh oh!

weizhouapache left a comment

Uh oh!

weizhouapache commented Jul 6, 2021

Uh oh!

shwstppr commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

shwstppr commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

Pearl1594 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

server: fix network access for addNicToVirtualMachine API #5184

server: fix network access for addNicToVirtualMachine API #5184

Uh oh!

Conversation

shwstppr commented Jul 5, 2021 • edited by weizhouapache Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jul 6, 2021

Uh oh!

shwstppr commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

shwstppr commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

blueorangutan commented Jul 6, 2021

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shwstppr commented Jul 5, 2021 •

edited by weizhouapache

Loading