Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR fixes traversal to the domain's detail tab on clicking on the router link present in any resource.
Currently, on clicking the router link of a domain doesn't select any active tab
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Post fix: Selects the Details tab as default active tab
image

@Pearl1594 Pearl1594 requested review from shwstppr and utchoang July 5, 2021 12:29
@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5182 (SL-JID-321)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested works fine

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaanHoogland DaanHoogland added this to the 4.16.0.0 milestone Jul 13, 2021
@nvazquez nvazquez closed this Jul 13, 2021
@nvazquez nvazquez reopened this Jul 13, 2021
@nvazquez nvazquez merged commit 9678c7b into apache:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants