Skip to content

Conversation

@utchoang
Copy link

@utchoang utchoang commented Jul 1, 2021

Description

Fixes #5177

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@utchoang utchoang changed the title [UI] zone wizard: change edit traffic type form of VMware [UI] zone wizard: change edit traffic type form of VMware Jul 1, 2021
@utchoang
Copy link
Author

utchoang commented Jul 1, 2021

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5178 (SL-JID-309)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. Forms with different fields show correctly for VMware and other hypervisors.
May need testing with an appropriate env to verify edited traffic label.

@DK101010
Copy link
Contributor

DK101010 commented Jul 2, 2021

Unfortunately, I cannot create another zone for the test due to a lack of resources. Code LGTM, but I get this error with the switch types:
Warning: You cannot set a form field before rendering a field associated with the value. You can use getFieldDecorator(id, options) instead v-decorator="[id, options]" to register it before render.

@rohityadavcloud rohityadavcloud added this to the 4.16.0.0 milestone Jul 5, 2021
@rohityadavcloud
Copy link
Member

Manual test necessary to merge this /cc @nvazquez @sureshanaparti

@nvazquez
Copy link
Contributor

@davidjumani can you please test this PR?

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested changes comparing API calls with old UI
New UI:
Screenshot from 2021-07-15 12-38-56

Old UI:
Screenshot from 2021-07-15 12-31-12

@rohityadavcloud rohityadavcloud merged commit 476f77a into apache:main Jul 15, 2021
@utchoang utchoang deleted the feature/vmware-edit-traffic-type branch July 15, 2021 07:35
@tombudghu
Copy link

tombudghu commented Jan 13, 2022

Hi all, we've come across an odd issue that might just have to do with this update. It is a VMware based setup. Configuring an advanced zone and defining multiple traffic types for some reason all of the vswitches are reset with values entered into the last configured. Imagine we configure vswitch0 for management traffic and then go on to configure a distributes switch (enabled using the appropriate parameter) for say guest traffic, it also changes the previously configured vswitch0.

Basically, we're unable to separate traffic to multiple VMware switches no. This behaviour we have not seen in 4.15. Any ideas, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Useability to configure traffic types for VMware zone is not good

7 participants