-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[UI] zone wizard: change edit traffic type form of VMware #5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] zone wizard: change edit traffic type form of VMware #5178
Conversation
edit traffic type form of VMware|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM. Forms with different fields show correctly for VMware and other hypervisors.
May need testing with an appropriate env to verify edited traffic label.
|
Unfortunately, I cannot create another zone for the test due to a lack of resources. Code LGTM, but I get this error with the switch types: |
|
Manual test necessary to merge this /cc @nvazquez @sureshanaparti |
|
@davidjumani can you please test this PR? |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi all, we've come across an odd issue that might just have to do with this update. It is a VMware based setup. Configuring an advanced zone and defining multiple traffic types for some reason all of the vswitches are reset with values entered into the last configured. Imagine we configure vswitch0 for management traffic and then go on to configure a distributes switch (enabled using the appropriate parameter) for say guest traffic, it also changes the previously configured vswitch0. Basically, we're unable to separate traffic to multiple VMware switches no. This behaviour we have not seen in 4.15. Any ideas, please? |


Description
Fixes #5177
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?