Skip to content

UI: Upgrade to Vue3 library #5151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvazquez merged 148 commits into from
Mar 9, 2022
Merged

UI: Upgrade to Vue3 library #5151

nvazquez merged 148 commits into from
Mar 9, 2022

Conversation

@utchoang
Copy link

@utchoang utchoang commented Jun 24, 2021 •
edited
Loading

Description

To Fixes #5093
This PR to migrate Vue and And library:

  • Vue 2 -> Vue 3
  • And 1.7.x -> And 2.x.x

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez nvazquez linked an issue Jul 13, 2021 that may be closed by this pull request
Upgrade to Vue3 library #5093
Closed
@sureshanaparti sureshanaparti added this to the 4.16.0.0 milestone Jul 16, 2021
utchoang added 13 commits July 27, 2021 09:15
Merge branch '4.15' into feature/upgrade-vue3-libray
4f57400 
# Conflicts:
#	ui/src/components/header/HeaderNotice.vue
#	ui/src/core/bootstrap.js
#	ui/src/core/lazy_lib/components_use.js
#	ui/src/main.js
#	ui/src/store/modules/user.js
#	ui/src/utils/plugins.js
#	ui/src/views/AutogenView.vue
#	ui/src/views/compute/CreateKubernetesCluster.vue
#	ui/src/views/compute/CreateSSHKeyPair.vue
#	ui/src/views/compute/CreateSnapshotWizard.vue
#	ui/src/views/compute/DeployVM.vue
#	ui/src/views/compute/DestroyVM.vue
#	ui/src/views/compute/EditVM.vue
#	ui/src/views/compute/ScaleKubernetesCluster.vue
#	ui/src/views/compute/StartVirtualMachine.vue
#	ui/src/views/compute/UpgradeKubernetesCluster.vue
#	ui/src/views/image/AddKubernetesSupportedVersion.vue
#	ui/src/views/image/IsoZones.vue
#	ui/src/views/image/RegisterOrUploadIso.vue
#	ui/src/views/image/RegisterOrUploadTemplate.vue
#	ui/src/views/image/TemplateZones.vue
#	ui/src/views/image/UpdateKubernetesSupportedVersion.vue
#	ui/src/views/network/CreateIsolatedNetworkForm.vue
#	ui/src/views/network/CreateL2NetworkForm.vue
#	ui/src/views/network/CreateSharedNetworkForm.vue
#	ui/src/views/network/CreateVlanIpRange.vue
#	ui/src/views/network/CreateVpc.vue
#	ui/src/views/network/CreateVpnCustomerGateway.vue
#	ui/src/views/project/InvitationTokenTemplate.vue
#	ui/src/views/storage/AttachVolume.vue
#	ui/src/views/storage/CreateVolume.vue
#	ui/src/views/storage/TakeSnapshot.vue
#	ui/src/views/storage/UploadLocalVolume.vue
user: fix by vue3
5a5bcef
Merge branch '4.15' into feature/upgrade-vue3-libray
3920a2b 
# Conflicts:
#	ui/src/components/view/ListView.vue
#	ui/src/views/network/CreateSharedNetworkForm.vue
iam: fix by vue3
e4b276a
fix zoneWizard & tooltip click event
140d862
fix infra > physicalnetwork & visible modal
bff863e
Merge branch '4.15' into feature/upgrade-vue3-libray
3ec54fb 
# Conflicts:
#	ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
fix infra by vue3 & antdv 2x
6bc44ff
fix offerings by vue3
14a56fd
fix plugin by vue3
13c225d
Merge branch '4.15' into feature/upgrade-vue3-libray
05dc417 
# Conflicts:
#	ui/src/views/network/AclListRulesTab.vue
#	ui/src/views/network/EgressRulesTab.vue
#	ui/src/views/network/FirewallRules.vue
#	ui/src/views/network/IngressEgressRuleConfigure.vue
#	ui/src/views/network/LoadBalancing.vue
#	ui/src/views/network/PortForwarding.vue
fix form & action form
738943f
update the ant-design latest version
3e560f1
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Aug 9, 2021

@utchoang I think there are huge no. of changes - are you strictly upgrading the library or also refactoring/rewriting components? Could this work be split into phases so some phase can still be completed for 4.16?

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1228)

@davidjumani
Copy link
Contributor

davidjumani commented Mar 9, 2022

@blueorangutan package

1 similar comment
@davidjumani
Copy link
Contributor

davidjumani commented Mar 9, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2802

@davidjumani
Copy link
Contributor

davidjumani commented Mar 9, 2022

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1230)

@davidjumani
Copy link
Contributor

davidjumani commented Mar 9, 2022

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@davidjumani
Copy link
Contributor

davidjumani commented Mar 9, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1231)

@blueorangutan
Copy link

blueorangutan commented Mar 9, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2809

nvazquez
nvazquez approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - manually tested and no major blockers found with the latest changes, will proceed with merging and fixing minor issues when found - great work @utchoang and all

@nvazquez nvazquez merged commit d258da5 into apache:main Mar 9, 2022
@kohrar kohrar mentioned this pull request Mar 21, 2022
Closed
@weizhouapache weizhouapache mentioned this pull request Apr 20, 2022
Merged
12 tasks
@sureshanaparti sureshanaparti mentioned this pull request Jun 21, 2022
Merged
10 tasks
@utchoang utchoang mentioned this pull request Jul 20, 2022
Closed
@shwstppr shwstppr mentioned this pull request Aug 10, 2022
Closed
weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request Mar 24, 2023
@weizhouapache
UI: fix default network is not passed to deployvm API
c352017 
This line is changed in apache#5080, but reverted in apache#5151
@weizhouapache weizhouapache mentioned this pull request Mar 24, 2023
Merged
12 tasks
weizhouapache added a commit that referenced this pull request Mar 28, 2023
@weizhouapache
UI: fix default network is not passed to deployvm API (#7367)
9e1c7a2 
This line was changed in #5080, but reverted in #5151
kishankavala pushed a commit to shapeblue/cloudstack that referenced this pull request Apr 13, 2023
@weizhouapache @kishankavala
UI: fix default network is not passed to deployvm API (apache#7367)
9e4f3a1 
This line was changed in apache#5080, but reverted in apache#5151
@nvazquez nvazquez mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 left review comments

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@NuxRo NuxRo NuxRo approved these changes

@nvazquez nvazquez nvazquez approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

@shwstppr shwstppr Awaiting requested review from shwstppr

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

@vladimirpetrov vladimirpetrov Awaiting requested review from vladimirpetrov

Assignees

No one assigned

Labels

component:UI status:needs-testing type:enhancement

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

Upgrade to Vue3 library

10 participants

@utchoang @rohityadavcloud @blueorangutan @davidjumani @sureshanaparti @Pearl1594 @nvazquez @NuxRo @svenvogel @borisstoyanov