Skip to content

Refactor and improvements for method com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.createVMFromSpec() #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvazquez merged 27 commits into from
Jul 21, 2021
Merged

Refactor and improvements for method com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.createVMFromSpec() #5149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
801f842
Refactor method createVMFromSpec
Jun 21, 2021
220672f
Add unit tests
Jun 21, 2021
e19f2a5
Fix test
Jun 23, 2021
631532b
Extract if block to method for add extra configs to VM Domain XML
Jun 24, 2021
bcec279
Merge branch 'main' into refactor-method-createVMFromSpec
Jun 29, 2021
827fd22
Split travis tests trying to isolate which test is causing an error
Jun 30, 2021
b1bbc53
Override toString() method
Jul 1, 2021
ff482d9
Update documentation
Jul 1, 2021
f9f2de7
Fix checkstyle error (line with trailing spaces)
Jul 1, 2021
fb37ef5
Change VirtualMachineTO print of object
Jul 1, 2021
7f49350
Add try except to find message error. Remove after test
Jul 2, 2021
62f8a2c
Fix indent
Jul 2, 2021
3a5dde9
Trying to understanding why is happening in this code
Jul 5, 2021
3292df6
Merge branch 'main' of https://github.com/apache/cloudstack into refa…
Jul 5, 2021
cc8df0f
Refactor method createVMFromSpec
Jun 21, 2021
2d3005e
Add unit tests
Jun 21, 2021
2d02ede
Fix test
Jun 23, 2021
e7a88ae
Extract if block to method for add extra configs to VM Domain XML
Jun 24, 2021
e35ee3c
Split travis tests trying to isolate which test is causing an error
Jun 30, 2021
9377161
Override toString() method
Jul 1, 2021
1bf0d0f
Update documentation
Jul 1, 2021
e2a52e5
Fix checkstyle error (line with trailing spaces)
Jul 1, 2021
58a4d73
Remove unnecessary comment
Jul 19, 2021
97205d7
Merge branch 'refactor-method-createVMFromSpec' of github.com:sccloud…
Jul 19, 2021
1c54f8a
Revert travis tests
Jul 19, 2021
89e32a8
Merge branch 'main' of https://github.com/apache/cloudstack into refa…
Jul 19, 2021
1eda61f
Merge branch 'main' of https://github.com/apache/cloudstack into refa…
Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,4 +413,9 @@ public DeployAsIsInfoTO getDeployAsIsInfo() {
public void setDeployAsIsInfo(DeployAsIsInfoTO deployAsIsInfo) {
this.deployAsIsInfo = deployAsIsInfo;
}

@Override
public String toString() {
return String.format("VM {id: \"%s\", name: \"%s\", uuid: \"%s\", type: \"%s\"}", id, name, uuid, type);
}
}
Loading