@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 318

@blueorangutan test

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@Pearl1594 this problem can be with other APIs as well.

(localcloud) SBCM5> > create domain name= 
{
  "domain": {
    "haschild": false,
    "id": "fad9ce01-c0ad-44bf-ae51-5f0a9ecc747b",
    "level": 1,
    "name": "",
    "parentdomainid": "4f507c55-cd47-11eb-bd54-1e009200048a",
    "parentdomainname": "ROOT",
    "path": "ROOT/",
    "secondarystoragetotal": 0
  }
}

Maybe we can add a check in ApiServer that when a param is required, it is not empty? cc @rhtyd @davidjumani

Updated API example

validations = {ApiArgValidator.NotNullOrEmpty} could be a generic solution in the Parameter annotation @shwstppr

validations = {ApiArgValidator.NotNullOrEmpty} could be a generic solution in the Parameter annotation @shwstppr

I agree with @davidjumani , why catch this one layer down if we can catch it before. I know we implemented this pattern a lot before in ACS but let's change our ways for the better, @Pearl1594 .

validations = {ApiArgValidator.NotNullOrEmpty} could be a generic solution in the Parameter annotation @shwstppr

I agree with @davidjumani , why catch this one layer down if we can catch it before. I know we implemented this pattern a lot before in ACS but let's change our ways for the better, @Pearl1594 .

Agreed @DaanHoogland, I was looking into fixing it, but seems another PR has been raised to address it in the meantime. I'll close this

Trillian test result (tid-1029)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35371 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5135-t1029-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below: