ui: refactor get api params in forms #5064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Based on testing and feasibility either of this PR or #5063 can be merged. |
shwstppr
force-pushed
the
refactor-ui-forms-getapiparams
branch
from
0abb5de to
b4a71c7
Compare
Refactor code getting api params for APIs in UI forms. Added a new util plugin in plugins.js Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
force-pushed
the
refactor-ui-forms-getapiparams
branch
from
b4a71c7 to
0978f4f
Compare
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Member
|
@shwstppr is this ready for review/testing/merge? |
Contributor
Author
|
@rhtyd yes, this is ready |
rohityadavcloud
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor code getting API params for APIs in UI forms.
Added a new util plugin in plugins.js
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?