Skip to content

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented May 21, 2021

Description

This PR supports ui bulk action for various resources. Following are addressed as part of this PR:

  • Bulk action support for various resources
  • Suppression of notification pop up (that appears on the top right corner of the screen) for async jobs in case the operation progress modal is open
  • Router links added to notification list for failed jobs/operations
  • Progress View - would have a filter column to filter the jobs by state
  • Cancel will be the default button for bulk operations
  • Different hue used for alert message for destructive bulk operations - like delete, stop, i,e, those that could lead to a possible down-time - to indicate to the users that such actions need to be performed with caution

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5034 (SL-JID-189)

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@Pearl1594 Pearl1594 closed this Jun 3, 2021
@Pearl1594 Pearl1594 reopened this Jun 3, 2021
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5034 (SL-JID-205)

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5034 (SL-JID-216)

@Pearl1594 Pearl1594 changed the title [WIP] UI: bulk action support for various resources UI: bulk action support for various resources Jun 7, 2021
@blueorangutan
Copy link

@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 323

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5034 (SL-JID-282)

@vladimirpetrov
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 391

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5034 (SL-JID-325)

@Pearl1594 Pearl1594 requested a review from vladimirpetrov July 6, 2021 08:17
Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following actions has been tested:
· VM: start, stop, restart, destroy (start, stop, destroy – already supported, but check implementation) - OK
· Kubernetes: start, stop, destroy - OK
· Instance groups: delete - OK
· SSH keypair: delete - OK
· Affinity groups: delete - OK
· Volumes: destroy - OK
· Snapshots: delete - OK
· VM snapshots: delete - OK
· Networks: restart, delete - OK
· VPC: restart, delete - OK
· Public IP Addresses: delete - OK
· VPN customer gateway and VPN users: delete - OK
· Firewall, port forwarding, LB rules: delete - OK
· Template and ISOs: delete (if feasible, as they are zone specific) - OK
· Events and Alerts: archive, delete (already supported, but check implementation) - OK
· Projects: active, suspend, delete - OK
· Accounts: enable, disable, lock, delete - OK
· Systemvms and Virtual Routers: stop, start, reboot and destroy - OK
· Internal LB: stop, start - OK
· Compute, system, disk and backup offerings: delete - OK
· Network and VPC offerings: enable, disable, delete - OK

The following functional changes were tested:
Suppress notifications (top right) when the progress view is open - OK
Router links added in the notification list view - OK
Display selected items in the confirmation & progress view - OK
Show only relevant columns in the confirmation / progress view - OK
Bulk action support for all user types - OK
Filter(in Progress view) on the operation status column - to filter jobs based on whether they are in progress, have succeeded or failed - OK
Different Alert message for destructive bulk actions like - delete*, stop*, expunge*, disassociate*, release* operations - OK
Cancel will be the default button for bulk operations - OK

In summary - LGTM

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monkey tested and superficial code review
lgtm

@DaanHoogland DaanHoogland marked this pull request as ready for review July 15, 2021 13:49
@DaanHoogland
Copy link
Contributor

@Pearl1594 can you look at the conflicts?

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@Pearl1594
Copy link
Contributor Author

Done @DaanHoogland

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5034 (SL-JID-364)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants