-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI: bulk action support for various resources #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 323 |
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 391 |
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
vladimirpetrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following actions has been tested:
· VM: start, stop, restart, destroy (start, stop, destroy – already supported, but check implementation) - OK
· Kubernetes: start, stop, destroy - OK
· Instance groups: delete - OK
· SSH keypair: delete - OK
· Affinity groups: delete - OK
· Volumes: destroy - OK
· Snapshots: delete - OK
· VM snapshots: delete - OK
· Networks: restart, delete - OK
· VPC: restart, delete - OK
· Public IP Addresses: delete - OK
· VPN customer gateway and VPN users: delete - OK
· Firewall, port forwarding, LB rules: delete - OK
· Template and ISOs: delete (if feasible, as they are zone specific) - OK
· Events and Alerts: archive, delete (already supported, but check implementation) - OK
· Projects: active, suspend, delete - OK
· Accounts: enable, disable, lock, delete - OK
· Systemvms and Virtual Routers: stop, start, reboot and destroy - OK
· Internal LB: stop, start - OK
· Compute, system, disk and backup offerings: delete - OK
· Network and VPC offerings: enable, disable, delete - OK
The following functional changes were tested:
Suppress notifications (top right) when the progress view is open - OK
Router links added in the notification list view - OK
Display selected items in the confirmation & progress view - OK
Show only relevant columns in the confirmation / progress view - OK
Bulk action support for all user types - OK
Filter(in Progress view) on the operation status column - to filter jobs based on whether they are in progress, have succeeded or failed - OK
Different Alert message for destructive bulk actions like - delete*, stop*, expunge*, disassociate*, release* operations - OK
Cancel will be the default button for bulk operations - OK
In summary - LGTM
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monkey tested and superficial code review
lgtm
|
@Pearl1594 can you look at the conflicts? |
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
Done @DaanHoogland |
|
UI build: ✔️ |
Description
This PR supports ui bulk action for various resources. Following are addressed as part of this PR:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?