volume resize: Fix issue with volume resize on VMWare (deploy as-is templates) #4829

Pearl1594 · 2021-03-16T14:52:27Z

Description

This PR fixes the issue pertaining to volume resize on VMWare for deploy as-is templates. VMware deploy as-is templates are those that are deployed as per the specification in the imported OVF. Hence override root disk size will not be adhered to for such templates. Moreover, when we deploy VMs in stopped state and resize the volume, the root disk doesn't get resized but the volume size is merely updated in the DB.
This PR also includes the following (for deploy as-is templates):

Disables overriding root disk size during VM deployment on the UI
Disables selection of compute offerings with root disk size specified, at the time of deployment
Provided users with the option to deploy VM is stopped state via UI (so as to give an option to users to resize the volumes before starting the VM)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Prior to the fix:

Deployed a VM in stopped state, resized volume from 3GB to 8GB

While the UI shows that the Volume is resized, the root volume inside the VM doesn't seem to have gotten resized:

Post fix

Deployed a VM in stopped state, resized the volume from 3GB to 8GB

Notice that the volume size as shown in the UI complies with the value inside the VM
Or verify the same on vcenter

…VM for deploy as it

…emplates)

Pearl1594 · 2021-03-16T14:53:16Z

@blueorangutan package

blueorangutan · 2021-03-16T14:54:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-16T15:11:57Z

Packaging result: ✖️ centos7 ✖️ centos8 ✖️ debian. SL-JID 138

Pearl1594 · 2021-03-16T15:14:34Z

@blueorangutan package

blueorangutan · 2021-03-16T15:16:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-16T15:46:55Z

Packaging result: ✖️ centos7 ✖️ centos8 ✔️ debian. SL-JID 140

nvazquez · 2021-03-16T16:50:21Z

@blueorangutan package

blueorangutan · 2021-03-16T16:51:02Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-16T17:17:37Z

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 141

nvazquez

Looks good - perhaps also adding a check on the resizevolume and fail with a message when the volume is created from a deploy-as-is template?

sureshanaparti · 2021-03-17T07:01:24Z

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

            for (DiskTO vol : sortedDisks) {
                if (vol.getType() == Volume.Type.ISO || deployAsIs && vol.getType() == Volume.Type.ROOT) {
+                    rootDiskTO = vol;
+                    resizeRootDiskOnVMStart(vmMo, rootDiskTO, hyperHost, context);


@Pearl1594 is this required for ISO as well?

Thanks @sureshanaparti It's not required for ISO , have made the necessary change.

… as is template

Pearl1594 · 2021-03-17T10:41:00Z

Looks good - perhaps also adding a check on the resizevolume and fail with a message when the volume is created from a deploy-as-is template?

@nvazquez added checks to see if a compute offering with root disk size mentioned is used / overriding root disk size is attempted when deploying a vm with deploy as-is template and will accordingly throw an exception.

Pearl1594 · 2021-03-17T12:07:50Z

@blueorangutan package

blueorangutan · 2021-03-17T12:08:41Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-17T12:50:23Z

Packaging result: ✔️ centos7 ✖️ centos8 ✖️ debian. SL-JID 156

Pearl1594 · 2021-03-17T12:58:57Z

@blueorangutan package

blueorangutan · 2021-03-17T13:00:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-17T13:26:54Z

Packaging result: ✖️ centos7 ✔️ centos8 ✔️ debian. SL-JID 158

Pearl1594 · 2021-03-17T13:34:42Z

@blueorangutan package

blueorangutan · 2021-03-17T13:35:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-17T14:09:46Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 160

Pearl1594 · 2021-03-17T14:15:42Z

@blueorangutan test matrix

blueorangutan · 2021-03-17T14:16:10Z

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests [S]

blueorangutan · 2021-03-22T06:40:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

ui/public/locales/en.json

ui/src/views/compute/DeployVM.vue

Pearl1594 · 2021-03-23T12:19:31Z

@blueorangutan package

blueorangutan · 2021-03-23T12:20:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-23T12:49:00Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 208

Pearl1594 · 2021-03-23T12:54:38Z

@blueorangutan test matrix

blueorangutan · 2021-03-23T12:55:02Z

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2021-03-23T22:47:24Z

Trillian test result (tid-227)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33443 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4829-t227-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Failure`	12.27	test_scale_vm.py

blueorangutan · 2021-03-23T23:26:15Z

Trillian test result (tid-228)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35299 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4829-t228-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	74.35	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	51.19	test_vm_life_cycle.py

blueorangutan · 2021-03-24T01:17:28Z

Trillian test result (tid-229)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42211 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4829-t229-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	796.21	test_kubernetes_clusters.py
ContextSuite context=TestVAppsVM>:setup	`Error`	43.39	test_vm_life_cycle.py

sureshanaparti

code LGTM

rohityadavcloud · 2021-03-24T06:56:23Z

Tests LGTM

rohityadavcloud · 2021-03-24T06:59:59Z

With @shwstppr to manually test it

shwstppr

Tested on VMware 65u2 env. Works fine.
UI disables Root disk resize option for newly registered templates unlike earlier where it was shown but not honoured.
Earlier

Now

Root volume resize of stopped VM deployed with a newly registered template (deployasis) - Successful
Root volume resize of stopped VM deployed with an ISO - Successfull

shwstppr

While volume resize behaviour works for most cases CKS cluster noderootdisksize is not working as expected. Will need similar changes from f5e866c

…ze-volume-issue

Pearl1594 · 2021-03-26T12:34:08Z

@blueorangutan package

blueorangutan · 2021-03-26T12:35:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-26T12:59:27Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 267

Pearl1594 · 2021-03-26T13:01:30Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-03-26T13:02:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

shwstppr

LGTM. Tested CKS node root disk resize with latest changes

Pearl Dsilva added 3 commits March 15, 2021 17:18

resize root disk + Hide override root disk size during deployment of …

26bbc1a

…VM for deploy as it

resize volume: Fix issue with volume resize on VMWare (deploy as-is t…

8b93bb2

…emplates)

Cleanup

5169c0c

Pearl1594 requested a review from nvazquez March 16, 2021 14:52

nvazquez reviewed Mar 16, 2021

View reviewed changes

sureshanaparti reviewed Mar 17, 2021

View reviewed changes

Add exceptions when svc offering with root disk size used with deploy…

f0a3d6e

… as is template

rohityadavcloud added this to the 4.15.1.0 milestone Mar 17, 2021

Allow resize of root disk for volume of a VM deployed from an ISO

1c3fc3c

nvazquez reviewed Mar 22, 2021

View reviewed changes

ui/public/locales/en.json Outdated Show resolved Hide resolved

ui/public/locales/en.json Outdated Show resolved Hide resolved

ui/src/views/compute/DeployVM.vue Outdated Show resolved Hide resolved

cleanup

4eda67e

nvazquez approved these changes Mar 24, 2021

View reviewed changes

Pearl1594 marked this pull request as ready for review March 24, 2021 04:25

sureshanaparti approved these changes Mar 24, 2021

View reviewed changes

rohityadavcloud assigned shwstppr Mar 24, 2021

shwstppr approved these changes Mar 26, 2021

View reviewed changes

shwstppr requested changes Mar 26, 2021

View reviewed changes

Pearl Dsilva added 2 commits March 26, 2021 17:34

Merge branch '4.15' of https://github.com/apache/cloudstack into resi…

3a05c9b

…ze-volume-issue

Support for volume resize for CKS

08faa04

shwstppr approved these changes Mar 26, 2021

View reviewed changes

rohityadavcloud merged commit 9717669 into apache:4.15 Mar 29, 2021

GabrielBrascher mentioned this pull request Jun 9, 2021

Failed to scale between Service Offerings with the same root disk size #5095

Merged

12 tasks

mib1185 mentioned this pull request Jun 10, 2021

ScaleVMCmd for ingested VMware VMs broken by #4829 #5096

Closed

volume resize: Fix issue with volume resize on VMWare (deploy as-is templates) #4829

volume resize: Fix issue with volume resize on VMWare (deploy as-is templates) #4829

Uh oh!

Conversation

Pearl1594 commented Mar 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Prior to the fix:

Post fix

Uh oh!

Pearl1594 commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

Pearl1594 commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

nvazquez commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

Pearl1594 commented Mar 17, 2021

Uh oh!

Pearl1594 commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

Pearl1594 commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

Pearl1594 commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

Pearl1594 commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pearl1594 commented Mar 23, 2021

Uh oh!

blueorangutan commented Mar 23, 2021

Uh oh!

blueorangutan commented Mar 23, 2021

Uh oh!

Pearl1594 commented Mar 23, 2021

Uh oh!

blueorangutan commented Mar 23, 2021

Pearl1594 commented Mar 16, 2021 •

edited

Loading