Skip to content

UI: Refactor async job polling codebase-wide #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvazquez merged 12 commits into from
Jul 19, 2021
Merged

UI: Refactor async job polling codebase-wide #4782

nvazquez merged 12 commits into from
Jul 19, 2021

Conversation

@utchoang
Copy link

@utchoang utchoang commented Mar 10, 2021 •
edited
Loading

Description

Related #4762
This PR to enhance asynchronous job exploration and improve load performance

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

BEFORE:
image
AFTER:
image

How Has This Been Tested?

Create VM -> Submit -> check the networks tab in browser developer tools

@utchoang utchoang mentioned this pull request Mar 10, 2021
Merged
12 tasks
@utchoang utchoang changed the base branch from master to 4.15 March 10, 2021 05:56
@utchoang utchoang marked this pull request as draft March 10, 2021 05:57
@utchoang utchoang closed this Mar 10, 2021
@utchoang utchoang reopened this Mar 10, 2021
@utchoang
Copy link
Author

utchoang commented Mar 11, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 11, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan
Copy link

blueorangutan commented Mar 11, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4782 (SL-JID-20)

@utchoang utchoang marked this pull request as ready for review March 11, 2021 10:01
@DaanHoogland DaanHoogland added this to the 4.15.1.0 milestone Mar 12, 2021
@utchoang utchoang mentioned this pull request Mar 16, 2021
Closed
Merge branch '4.15' into feature/refactor-async-job
853fb99 
# Conflicts:
#	ui/src/views/compute/StartVirtualMachine.vue
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Mar 30, 2021

@utchoang this looks like a major codebase-wide feature change, I'm moving to 4.16/master. Thanks.

@rohityadavcloud rohityadavcloud modified the milestones: 4.15.1.0, 4.16.0.0 Mar 30, 2021
@nvazquez
Copy link
Contributor

nvazquez commented Jun 23, 2021 •
edited
Loading

Hi @utchoang can you please resolve the conflicts?

@shwstppr
Copy link
Contributor

shwstppr commented Jul 14, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 14, 2021

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 14, 2021

UI build: ✖️
(SL-JID-358)

@utchoang
Copy link
Author

utchoang commented Jul 15, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 16, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4782 (SL-JID-368)

@nvazquez
Copy link
Contributor

nvazquez commented Jul 19, 2021

Thanks @davidjumani for testing
@utchoang one concern raised by @davidjumani, I've seen the network providers addition has been refactored as well, were you able to test them?

@davidjumani
Copy link
Contributor

davidjumani commented Jul 19, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 19, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 19, 2021

UI build: ✖️
(SL-JID-377)

@davidjumani
Copy link
Contributor

davidjumani commented Jul 19, 2021

@utchoang

/jenkins/workspace/acs-ui-builder/ui/src/views/infra/network/providers/AddNetscalerLoadBalancer.vue
  295:17  error  'jobId' is assigned a value but never used  no-unused-vars

@utchoang
Copy link
Author

utchoang commented Jul 19, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 19, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 19, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4782 (SL-JID-378)

davidjumani
davidjumani reviewed Jul 19, 2021
View reviewed changes
@davidjumani
Copy link
Contributor

davidjumani commented Jul 19, 2021

Tested the Network Providers, the async job calls work fine, @utchoang Can you close the add network providers forms after submitting it rather than waiting for the async jobs to complete

davidjumani
davidjumani reviewed Jul 19, 2021
View reviewed changes
davidjumani
davidjumani reviewed Jul 19, 2021
View reviewed changes
davidjumani
davidjumani reviewed Jul 19, 2021
View reviewed changes
@utchoang
Copy link
Author

utchoang commented Jul 19, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 19, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 19, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4782 (SL-JID-381)

davidjumani
davidjumani approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @utchoang
@nvazquez Good to go!

@nvazquez
Copy link
Contributor

nvazquez commented Jul 19, 2021

Thanks @davidjumani @utchoang

@nvazquez nvazquez merged commit 535761b into apache:4.15 Jul 19, 2021
@utchoang utchoang deleted the feature/refactor-async-job branch July 20, 2021 00:23
@nvazquez nvazquez modified the milestones: 4.16.0.0, 4.15.2.0 Jul 20, 2021
@davidjumani davidjumani mentioned this pull request Jul 20, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@davidjumani davidjumani davidjumani approved these changes

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@davidjumani davidjumani

Labels

component:UI

Projects

None yet

Milestone

4.15.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@utchoang @blueorangutan @rohityadavcloud @nvazquez @shwstppr @davidjumani @DaanHoogland