Skip to content

UI: Add cancel button missing on dialog #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 2 commits into from
Mar 29, 2021
Merged

UI: Add cancel button missing on dialog #4763

rohityadavcloud merged 2 commits into from
Mar 29, 2021

Conversation

@utchoang
Copy link

@utchoang utchoang commented Mar 8, 2021 •
edited
Loading

Description

This PR for the fix to add cancel button missing on dialog

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

After fix:
image

How Has This Been Tested?

@utchoang utchoang closed this Mar 8, 2021
@utchoang utchoang deleted the feature/dialog-add-cancel-button branch March 8, 2021 06:23
@utchoang utchoang restored the feature/dialog-add-cancel-button branch March 8, 2021 06:23
@utchoang utchoang reopened this Mar 8, 2021
@utchoang utchoang mentioned this pull request Mar 8, 2021
Merged
12 tasks
@utchoang
Copy link
Author

utchoang commented Mar 8, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4763 (JID-3853)

@DaanHoogland DaanHoogland added this to the 4.15.1.0 milestone Mar 8, 2021
@utchoang utchoang marked this pull request as draft March 9, 2021 01:57
@utchoang utchoang marked this pull request as ready for review March 11, 2021 08:59
@utchoang utchoang mentioned this pull request Mar 16, 2021
Closed
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Mar 24, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4763 (SL-JID-54)

@davidjumani
Copy link
Contributor

davidjumani commented Mar 25, 2021

@utchoang Could you remove the commit d998f27 and push ?

@utchoang utchoang closed this Mar 25, 2021
@utchoang utchoang force-pushed the feature/dialog-add-cancel-button branch from a6297a8 to 3a82392 Compare March 25, 2021 07:19
@utchoang utchoang reopened this Mar 25, 2021
@davidjumani
Copy link
Contributor

davidjumani commented Mar 25, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4763 (SL-JID-73)

davidjumani
davidjumani approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohityadavcloud rohityadavcloud merged commit 3e8dbc0 into apache:4.15 Mar 29, 2021
@utchoang utchoang deleted the feature/dialog-add-cancel-button branch March 30, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidjumani davidjumani davidjumani approved these changes

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@davidjumani davidjumani

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@utchoang @blueorangutan @rohityadavcloud @davidjumani @DaanHoogland