Added disk provisioning type support for VMWare #4640
Conversation
|
@Spaceman1984 can you kick pkging and testing, is this still in WIP - pl change it to draft. Thanks. |
|
@blueorangutan test ? |
|
@blueorangutan package |
Spaceman1984
requested review from
Pearl1594,
harikrishna-patnala,
nvazquez and
sureshanaparti
and removed request for
Pearl1594
|
@blueorangutan package |
|
@blueorangutan test ? |
|
@blueorangutan test centos7 ? |
|
@blueorangutan test centos7 vmware-67u3 |
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
@Spaceman1984 May I know what happens if strictness is set to false and disk is provisioned on unsupported storage pool ?
...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
Outdated
Show resolved
Hide resolved
...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStorageCapabilitiesCmd.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStorageCapabilitiesCmd.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStorageCapabilitiesCmd.java
Outdated
Show resolved
Hide resolved
...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
Outdated
Show resolved
Hide resolved
...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
Outdated
Show resolved
Hide resolved
...lume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
Show resolved
Hide resolved
...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
Outdated
Show resolved
Hide resolved
...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/cloud/server/ManagementServerImpl.java
Outdated
Show resolved
Hide resolved
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
Show resolved
Hide resolved
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
Show resolved
Hide resolved
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
Show resolved
Hide resolved
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
Outdated
Show resolved
Hide resolved
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
Show resolved
Hide resolved
@harikrishna-patnala If strictness is set to false, a thin disk will be created on the unsupported pool. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 540 |
|
@blueorangutan test centos7 vmware-67u3 |
|
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests |
|
@blueorangutan package |
|
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 556 |
|
@blueorangutan test centos7 vmware-67u3 |
|
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests |
|
Trillian test result (tid-1279)
|
|
@Spaceman1984 is this PR ready for merge? |
|
Should be good to go @nvazquez |
This reverts commit 2486db7.
|
@blueorangutan package |
|
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 568 |
|
@blueorangutan test centos7 vmware-67u3 |
|
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests |
|
Trillian test result (tid-1293)
|
7 participants
Description
This PR adds the ability to create thick and sparse disks using VMWare
A global variable (disk.provisioning.type.strictness) has been added to select if disk provisioning types will be strictly adhered to, meaning if a storage pool is not capable of creating the specific disk provisioning type, the pool will not be selected for the creation of the volume.
StoragePool capabilities are determined when the pool is added to Cloudstack and a new API is added ( updateStorageCapabilities(poolId) ) to update the hardware acceleration capability of storage pools if needed.
Doc PR here: apache/cloudstack-documentation#217
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
Marvin tests have been added and manual tests have been done using NFS without hardware acceleration and an ISCSI datastore.
Create a thin/sparse/thick disk/service offering, set the global var to true, depending on the offering selected, the disks should be created in the correct storage pool with the correct disk provisioning type.
If the global var is set to false, the disk will be created in any storage pool and if the pool supports the disk provisioning type it will be used, otherwise thin will be selected.