Support for persistence mode in L2 networks #4561

Pearl1594 · 2020-12-30T11:05:33Z

Description

This PR aims at introducing persistence mode in L2 networks and enhancing the behavior in Isolated networks

Doc PR apache/cloudstack-documentation#183

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

Major
Minor

rohityadavcloud · 2020-12-30T11:26:53Z

@blueorangutan package

blueorangutan · 2020-12-30T11:28:09Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java

blueorangutan · 2020-12-30T12:04:47Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2521

nvazquez

Looks good, leaving some review comments

engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

...vm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java

server/src/main/java/com/cloud/network/NetworkServiceImpl.java

Pearl1594 · 2021-01-19T10:20:53Z

@blueorangutan package

blueorangutan · 2021-01-19T10:21:36Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-01-19T10:54:28Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2549

Pearl1594 · 2021-01-19T10:55:41Z

@blueorangutan test matrix

blueorangutan · 2021-01-19T10:56:31Z

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2021-01-19T20:51:22Z

Trillian test result (tid-3394)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34163 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4561-t3394-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_domain_network_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_persistent_network.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 84 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_create_network_domain_network_offering	`Error`	1.39	test_domain_network_offerings.py
ContextSuite context=TestL2PersistentNetworks>:setup	`Error`	0.00	test_persistent_network.py
test_01_scale_vm	`Failure`	9.24	test_scale_vm.py

blueorangutan · 2021-01-19T22:33:00Z

Trillian test result (tid-3395)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40093 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4561-t3395-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_domain_network_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_persistent_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_create_network_domain_network_offering	`Error`	1.37	test_domain_network_offerings.py
ContextSuite context=TestL2PersistentNetworks>:setup	`Error`	0.00	test_persistent_network.py

blueorangutan · 2021-01-19T22:34:35Z

Trillian test result (tid-3396)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40396 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4561-t3396-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_domain_network_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_persistent_network.py
Smoke tests completed. 84 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_create_network_domain_network_offering	`Error`	1.38	test_domain_network_offerings.py
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	774.87	test_kubernetes_clusters.py
ContextSuite context=TestL2PersistentNetworks>:setup	`Error`	0.00	test_persistent_network.py

Pearl1594 · 2021-01-20T12:47:52Z

@blueorangutan package

blueorangutan · 2021-01-20T12:48:35Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-01-20T13:27:21Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2556

Pearl1594 · 2021-01-20T13:57:22Z

@blueorangutan test

blueorangutan · 2021-01-20T13:58:42Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Pearl1594 · 2021-01-21T07:47:41Z

@blueorangutan package

blueorangutan · 2021-01-21T07:48:39Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-01-21T08:55:41Z

Packaging result: ✖centos7 ✖centos8 ✔debian. JID-2563

Pearl1594 · 2021-01-21T08:58:45Z

@blueorangutan package

blueorangutan · 2021-01-21T08:59:44Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

…rsistent-nw-enhance

rohityadavcloud · 2021-03-29T10:42:11Z

@Pearl1594 is this ready for merging?
@blueorangutan package

blueorangutan · 2021-03-29T10:43:03Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Pearl1594 · 2021-03-29T10:45:05Z

It is ready for merging @rhtyd

rohityadavcloud · 2021-03-29T10:46:00Z

@Pearl1594 thnx, pl kick a round of smoketests once packaging is done.

Pearl1594 · 2021-03-29T10:48:14Z

will do, thanks @rhtyd

Pearl1594 · 2021-03-29T12:07:08Z

@blueorangutan package

blueorangutan · 2021-03-29T12:08:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-29T12:33:25Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 282

rohityadavcloud · 2021-03-29T12:34:17Z

@blueorangutan test matrix

blueorangutan · 2021-03-29T12:35:03Z

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2021-03-29T13:34:40Z

Trillian Build Failed (tid-288)

rohityadavcloud · 2021-03-29T13:44:47Z

@blueorangutan test

blueorangutan · 2021-03-29T13:46:03Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-29T14:27:00Z

Trillian Build Failed (tid-296)

Pearl1594 · 2021-03-29T16:31:30Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2021-03-29T16:32:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Pearl1594 · 2021-03-29T16:32:45Z

@blueorangutan test

blueorangutan · 2021-03-29T16:34:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-30T00:04:58Z

Trillian test result (tid-287)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37142 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4561-t287-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	82.83	test_kubernetes_clusters.py
test_01_scale_vm	`Failure`	9.22	test_scale_vm.py

blueorangutan · 2021-03-30T03:30:45Z

Trillian test result (tid-299)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36623 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4561-t299-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	75.51	test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume	`Error`	67.23	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	52.13	test_vm_life_cycle.py

rohityadavcloud · 2021-04-05T09:06:50Z

Comparing last test run and results, LGTM.

rohityadavcloud requested review from nvazquez and rohityadavcloud December 30, 2020 11:15

rohityadavcloud added this to the 4.16.0.0 milestone Dec 30, 2020

rohityadavcloud reviewed Dec 30, 2020

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java Outdated Show resolved Hide resolved

nvazquez reviewed Dec 30, 2020

View reviewed changes

Pearl1594 force-pushed the persistent-nw-enhance branch from 65e4938 to cf5cb95 Compare January 5, 2021 06:47

Pearl1594 force-pushed the persistent-nw-enhance branch from 2ffcb72 to c92652b Compare January 13, 2021 05:38

Pearl1594 force-pushed the persistent-nw-enhance branch from 6a80736 to b898d6f Compare January 21, 2021 08:04

Pearl1594 force-pushed the persistent-nw-enhance branch from b898d6f to f053803 Compare January 21, 2021 09:19

Merge branch 'master' of https://github.com/apache/cloudstack into pe…

d659db8

…rsistent-nw-enhance

rohityadavcloud marked this pull request as ready for review March 29, 2021 10:45

rohityadavcloud changed the title ~~[WIP] Support for persistence mode in L2 networks~~ Support for persistence mode in L2 networks Mar 29, 2021

apache deleted a comment from blueorangutan Apr 5, 2021

rohityadavcloud merged commit 0dbeb26 into apache:master Apr 5, 2021

weizhouapache mentioned this pull request Jun 7, 2021

Error while remove vxlan on kvm hosts in ACS 4.16 #5077

Closed

Pearl1594 mentioned this pull request Jun 7, 2021

vxlan: Fix failure to delete vxlan #5079

Merged

10 tasks

nvazquez added Severity:Major type:new-feature labels Oct 14, 2021

Support for persistence mode in L2 networks #4561

Support for persistence mode in L2 networks #4561

Uh oh!

Conversation

Pearl1594 commented Dec 30, 2020 • edited by rohityadavcloud Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale

Uh oh!

rohityadavcloud commented Dec 30, 2020

Uh oh!

blueorangutan commented Dec 30, 2020

Uh oh!

Uh oh!

blueorangutan commented Dec 30, 2020

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pearl1594 commented Jan 19, 2021

Uh oh!

blueorangutan commented Jan 19, 2021

Uh oh!

blueorangutan commented Jan 19, 2021

Uh oh!

Pearl1594 commented Jan 19, 2021

Uh oh!

blueorangutan commented Jan 19, 2021

Uh oh!

blueorangutan commented Jan 19, 2021

Uh oh!

blueorangutan commented Jan 19, 2021

Uh oh!

blueorangutan commented Jan 19, 2021

Uh oh!

Pearl1594 commented Jan 20, 2021

Uh oh!

blueorangutan commented Jan 20, 2021

Uh oh!

blueorangutan commented Jan 20, 2021

Uh oh!

Pearl1594 commented Jan 20, 2021

Uh oh!

blueorangutan commented Jan 20, 2021

Uh oh!

Pearl1594 commented Jan 21, 2021

Uh oh!

blueorangutan commented Jan 21, 2021

Uh oh!

blueorangutan commented Jan 21, 2021

Uh oh!

Pearl1594 commented Jan 21, 2021

Uh oh!

blueorangutan commented Jan 21, 2021

Uh oh!

rohityadavcloud commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

Pearl1594 commented Mar 29, 2021

Uh oh!

rohityadavcloud commented Mar 29, 2021

Uh oh!

Pearl1594 commented Mar 29, 2021

Uh oh!

Pearl1594 commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

Pearl1594 commented Dec 30, 2020 •

edited by rohityadavcloud

Loading