Integrate Tungsten Fabric with CloudStack #4205

radu-todirica · 2020-07-06T15:29:49Z

Description

WORK IN PROGRESS
Integration of TUNGSTEN SDN in Cloudstack

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland · 2020-07-29T11:02:51Z

Nice to see this moving on. Please let us know as soon as you need review or other feedback, @radu-todirica

svenvogel · 2020-07-30T13:58:18Z

@radu-todirica @huyle-uni changed name to Tungsten Fabric. 👍

...c/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenProvidersCmd.java

plugins/network-elements/tungsten/pom.xml

...n/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenGuestNetworkGuru.java

engine/schema/src/main/java/com/cloud/network/TungstenGuestNetworkIpAddressVO.java

server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

engine/schema/src/main/java/com/cloud/network/element/TungstenProviderVO.java

plugins/network-elements/tungsten/pom.xml

utils/src/main/java/com/cloud/utils/TungstenUtils.java

swill

The majority of my comments are around using "tungsten fabric" instead of "tungsten" in end user facing documentation, such as the API docs. I don't think this is required, but will help with SEO and the ability for end users to find the appropriate documentation when searching later.

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java

api/src/main/java/org/apache/cloudstack/api/response/NetworkOfferingResponse.java

api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/VRouterVifDriver.java

...c/main/java/org/apache/cloudstack/network/tungsten/api/command/ConfigTungstenServiceCmd.java

.../main/java/org/apache/cloudstack/network/tungsten/api/command/CreateTungstenProviderCmd.java

...c/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenProvidersCmd.java

pom.xml

ui/scripts/docs.js

DaanHoogland

@radu-stefanache I had a first go and added some github sugestions for your convenience.
I will do a second more intensive pass and a colleague is trying out tungsten ,but we are focussing on internal (vlan/vxlan based) SDN at the moment so it is very low priority for us for the time coming.

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java

api/src/main/java/org/apache/cloudstack/api/response/NetworkOfferingResponse.java

api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java

DaanHoogland · 2021-06-04T11:12:07Z

client/pom.xml

-            <id>juniper-contrail</id>
-            <url>https://juniper.github.io/contrail-maven/snapshots</url>
+            <id>juniper-tungsten-api</id>
+            <url>https://github.com/radu-todirica/tungsten-api/raw/master</url>


is this going to be moved elsewhere?

Yes. This jar needs to be moved to a Cloudstack repository.

New source is https://github.com/kiwiflyer/tf-java-api

.../main/java/org/apache/cloudstack/network/tungsten/api/command/CreateTungstenProviderCmd.java

.../java/org/apache/cloudstack/network/tungsten/api/command/CreateTungstenPublicNetworkCmd.java

...ava/org/apache/cloudstack/network/tungsten/api/command/GetLoadBalancerSslCertificateCmd.java

...c/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenProvidersCmd.java

rohityadavcloud · 2021-06-10T08:29:14Z

Hi @radu-todirica @kiwiflyer can you advise the current state and (future) plans on supported hypervisors (does it only support KVM, or also or have plans to support for VMware and XenServer)? I'm asking as we're exploring a feature around general-purpose NFVs and servicing chaining framework in CloudStack (that would allow users to BYO router/appliance).

blueorangutan · 2022-11-16T10:27:18Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✔️ suse15. LL-JID 277

kiwiflyer · 2022-11-16T11:55:38Z

Also need to discuss pulling this into CloudStack, or figuring out an alternative build option - https://github.com/radu-todirica/tungsten-api/

kiwiflyer · 2022-11-16T12:00:30Z

Also need to discuss pulling this into CloudStack, or figuring out an alternative build option - https://github.com/radu-todirica/tungsten-api/

@radu-todirica Do you have any build notes for the above jar? Is there a reference for the original source? Since it's a binary, we need to figure out whether we pull it in as a jar (already built), or whether we can build it during compile. If we add it as a jar, it may have to go in the non-open source version, since it's precompiled.

radu-todirica · 2022-11-16T12:40:14Z

@kiwiflyer yes. Here you have the source code that generates that jar file.
https://github.com/radu-todirica/tungsten-api-sourceCode

DaanHoogland · 2022-11-28T14:19:56Z

@radu-todirica @kiwiflyer can we somehow integrate this so packaging succeeds for all platforms?

@kiwiflyer yes. Here you have the source code that generates that jar file. https://github.com/radu-todirica/tungsten-api-sourceCode

kiwiflyer · 2022-11-30T21:41:29Z

@radu-todirica @kiwiflyer can we somehow integrate this so packaging succeeds for all platforms?

@kiwiflyer yes. Here you have the source code that generates that jar file. https://github.com/radu-todirica/tungsten-api-sourceCode

@radu-todirica Is there a way we build this via Mavin sourced from the Tungsten repo?

radu-todirica · 2022-12-05T13:42:08Z

@kiwiflyer I don't think so. If i'm not mistaken we made some small changes to our version in order to work. @huyle-uni we did some changes right?

DaanHoogland · 2022-12-05T15:06:36Z

@kiwiflyer I don't think so. If i'm not mistaken we made some small changes to our version in order to work. @huyle-uni we did some changes right?

ok, this gives some legal consequenses;

We must make those changes public. So if we can´t get it merged upstream we must point to a fork with the changes somewhere or package the diff.
we must make this part of the noredist build.

can we make this happen before the new year @radu-todirica @huyle-uni ?

github-actions · 2022-12-05T18:53:55Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2022-12-13T09:29:45Z

@radu-todirica @kiwiflyer @huyle-uni we have conflicts here, can you have a look, please?

kiwiflyer · 2022-12-13T13:24:39Z

@svenvogel see above. Is your team aware of whether any changes were made in the tungsten api jar to support CloudStack? We need to get that package to the PMC for a vote.

kiwiflyer · 2022-12-13T13:25:14Z

@radu-todirica can you rebase? Looks like we have a conflict.

…icts

DaanHoogland · 2022-12-16T15:10:29Z

@blueorangutan package

blueorangutan · 2022-12-16T15:11:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

kiwiflyer · 2022-12-16T19:49:47Z

@DaanHoogland
I've forked the original Tungsten API and pulled in the changes that @huyle-uni and @radu-todirica made -
Here's the repo - https://github.com/kiwiflyer/tf-java-api

DaanHoogland · 2022-12-19T09:54:43Z

@DaanHoogland I've forked the original Tungsten API and pulled in the changes that @huyle-uni and @radu-todirica made - Here's the repo - https://github.com/kiwiflyer/tf-java-api

great, did you make that into a pull request to the upstream?
and should we have a nonoss jar to include in under the -D nonoss option?

github-actions · 2022-12-22T12:04:08Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

rohityadavcloud · 2023-01-04T06:43:06Z

@kiwiflyer can help in addressing merge conflicts and publishing the java API on maven (alt. we can build/pkg the jar in the ext. dependency repo https://github.com/shapeblue/cloudstack-nonoss but that would require putting the feature to build only for -Dnoredist flag)

davidjumani · 2023-01-12T04:43:51Z

Closing as the feature is continued in #7065

svenvogel added component:kvm component:networking labels Jul 6, 2020

svenvogel changed the title ~~WIP - Integrate tungsten with cloudstack~~ WIP - Integrate Tungsten Fabric with CloudStack Jul 30, 2020

DaanHoogland changed the title ~~WIP - Integrate Tungsten Fabric with CloudStack~~ Integrate Tungsten Fabric with CloudStack Jul 31, 2020

ACSGitBot added status:wip type:new_feature labels Nov 3, 2020

DaanHoogland added type:new-feature and removed type:new_feature labels Nov 10, 2020

DaanHoogland reviewed Nov 25, 2020

View reviewed changes

...c/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenProvidersCmd.java Outdated Show resolved Hide resolved

utchoang mentioned this pull request Dec 8, 2020

[WIP] Integrate Tungsten Fabric with Primate apache/cloudstack-primate#892

Draft

3 tasks

DaanHoogland reviewed Dec 16, 2020

View reviewed changes

plugins/network-elements/tungsten/pom.xml Outdated Show resolved Hide resolved

DaanHoogland reviewed Dec 16, 2020

View reviewed changes

...n/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenGuestNetworkGuru.java Outdated Show resolved Hide resolved

DaanHoogland reviewed Dec 16, 2020

View reviewed changes

...n/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenGuestNetworkGuru.java Outdated Show resolved Hide resolved

DaanHoogland requested changes Mar 18, 2021

View reviewed changes

...n/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenGuestNetworkGuru.java Outdated Show resolved Hide resolved

engine/schema/src/main/java/com/cloud/network/TungstenGuestNetworkIpAddressVO.java Show resolved Hide resolved

utchoang mentioned this pull request Apr 2, 2021

UI: Integrate Tungsten Fabric #4889

Closed

12 tasks