Bug fix: Dont display empty item in free ip list#3790
Merged
Conversation
5 tasks
Contributor
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Contributor
|
thx for the fix @rakgenius! |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-510 |
Contributor
|
LGTM - tested manually. |
Contributor
|
Merging based on 2 x LGTM - no tests needed - a simple JS change. |
wqmeng
added a commit
to wqmeng/cloudstack
that referenced
this pull request
Jan 2, 2020
Bug fix: Dont display empty item in free ip list (apache#3790)
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the empty item from the free IP list when we click on "Acquire New IP" in the networks section.
If we dont select any IP address from the list and click ok, it sends "ipaddress=-1" as the parameter which is not back compatible.
This fix ensures that no empty item is displayed and by default one valid ip selected. So when we click ok, "ipaddress=-1" wont be sent as a parameter to the api call.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
1 . Navigate to "Networks" section in the main UI
2 . Select any network from the list.
3 . Click on "View IP address" button.
4 . Now click on "Acquire New IP" button on the top right. This will open up a new pop up window with drop down list of all IP address belonging to that network
5 . Select any of the IP address.