New feature: Acquire specific public IP for network by ravening · Pull Request #3775 · apache/cloudstack

ravening · 2019-12-18T15:50:00Z

Description

Currently in cloudstack, when we click on "Acquire New Ip", it will
randomly acquire IP from the pool. With this enhancement, it is
possible to select the IP from the drop down IP list of that network.
Same thing applies for a VPC as well.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

1 . Navigate to "Networks" section in the main UI
2 . Select any network from the list.
3 . Click on "View IP address" button.
4 . Now click on "Acquire New IP" button on the top right. This will open up a new pop up window with drop down list of all IP address belonging to that network
5 . Select any of the IP address.

Currently in cloudstack, when we click on "Acquire New Ip", it will randomly acquire IP from the pool. With this enhancement, it is possible to select the IP from the drop down IP list of that network. Same thing applies for a VPC as well.

DaanHoogland

code looks good, marvin test included. wonder if unit test would make sense.

div8cn · 2019-12-20T01:12:59Z

Can I specify a public IP when creating an isolated network or VPC?

anuragaw

Code looks good. Haven't tested though.

One question - When the IP Address requested is invalid or unavailable in user_ip_address do we add that reason in exception or log it? (could'nt see it).

ravening · 2019-12-20T14:14:29Z

Can I specify a public IP when creating an isolated network or VPC?

If you comment out the first diff in network.js then you can specify any free IP in that network or VPC

ravening · 2019-12-20T14:16:45Z

Code looks good. Haven't tested though.

One question - When the IP Address requested is invalid or unavailable in user_ip_address do we add that reason in exception or log it? (could'nt see it).

The dropdown displays only the "Free" IP's available in that particular network or VPC. If there are not free IP in that network/VPC then it wont display the drop down list

anuragaw · 2019-12-20T14:47:23Z

Code looks good. Haven't tested though.
One question - When the IP Address requested is invalid or unavailable in user_ip_address do we add that reason in exception or log it? (could'nt see it).

The dropdown displays only the "Free" IP's available in that particular network or VPC. If there are not free IP in that network/VPC then it wont display the drop down list

But that doesn't cover API usage outside UI @rakgenius , which is how a large number of users access CS.

ravening · 2019-12-20T15:44:39Z

Code looks good. Haven't tested though.
One question - When the IP Address requested is invalid or unavailable in user_ip_address do we add that reason in exception or log it? (could'nt see it).

The dropdown displays only the "Free" IP's available in that particular network or VPC. If there are not free IP in that network/VPC then it wont display the drop down list

But that doesn't cover API usage outside UI @rakgenius , which is how a large number of users access CS.

@anuragaw Just tested it and if the IP is already allocated, it will throw Insufficient address capacity exception

(local) 🐵 > associate ipaddress networkid=6efa8597-d5e8-4bf6-8686-3db26d568ed1 ipaddress=10.11.113.150

{
  "accountid": "9c185c1d-00b2-11ea-a7cf-069f80000fac",
  "cmd": "org.apache.cloudstack.api.command.admin.address.AssociateIPAddrCmdByAdmin",
  "completed": "2019-12-20T15:38:35+0000",
  "created": "2019-12-20T15:38:35+0000",
  "jobid": "ca7f3410-a1be-43ec-880e-448facff96c7",
  "jobinstanceid": "f7a584ca-8a3c-4f72-b647-c92ed31397aa",
  "jobinstancetype": "IpAddress",
  "jobprocstatus": 0,
  "jobresult": {
    "ipaddress": {
      "account": "test",
      "allocated": "2019-12-20T15:38:35+0000",
      "associatednetworkname": "test",
      "domain": "test",
      "fordisplay": true,
      "forvirtualnetwork": true,
      "id": "f7a584ca-8a3c-4f72-b647-c92ed31397aa",
      "ipaddress": "10.11.113.150",
      "isportable": false,
      "issourcenat": false,
      "isstaticnat": false,
      "issystem": false,
      "state": "Allocating",
      "tags": [],
      "vlanname": "vlan://untagged",
      "zonename": "zone113-2"
    }
  },
  "jobresultcode": 0,
  "jobresulttype": "object",
  "jobstatus": 1
}

(local) 🐵 > associate ipaddress networkid=6efa8597-d5e8-4bf6-8686-3db26d568ed1 ipaddress=10.11.113.150
Error 533: Insufficient address capacity

2019-12-20 15:42:35,163 WARN  [c.c.n.IpAddressManagerImpl] (qtp858242339-18:ctx-9d0b2eb1 ctx-a86c335b) (logid:5b743076) Unable to get ip address in  zone id=1, vlanId id=[1]: requested ip 10.11.113.150 is not available
2019-12-20 15:42:35,264 TRACE [o.a.c.a.c.u.a.AssociateIPAddrCmd] (qtp858242339-18:ctx-9d0b2eb1 ctx-a86c335b) (logid:5b743076) com.cloud.exception.InsufficientAddressCapacityException: Insufficient address capacityScope=interface com.cloud.dc.DataCenter; id=1
2019-12-20 15:42:35,264 INFO  [c.c.a.ApiServer] (qtp858242339-18:ctx-9d0b2eb1 ctx-a86c335b) (logid:5b743076) Insufficient address capacity

anuragaw

Perfect, that's what I was looking for. Some mention of IP not available along with the exception. Even though it's a warning- 2019-12-20 15:42:35,163 WARN [c.c.n.IpAddressManagerImpl] (qtp858242339-18:ctx-9d0b2eb1 ctx-a86c335b) (logid:5b743076) Unable to get ip address in zone id=1, vlanId id=[1]: requested ip 10.11.113.150 is not available

anuragaw · 2019-12-20T15:58:20Z

Running Marvin Tests on the PR.

@blueorangutan package

blueorangutan · 2019-12-20T15:58:24Z

@anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-12-20T16:18:18Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-497

anuragaw · 2019-12-20T16:18:41Z

@blueorangutan test

blueorangutan · 2019-12-20T16:19:24Z

@anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

anuragaw · 2019-12-20T16:29:29Z

We can merge after tests job above succeeds.

blueorangutan · 2019-12-21T03:04:25Z

Trillian test result (tid-660)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36796 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3775-t660-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	`Failure`	415.34	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	442.73	test_vpc_redundant.py

anuragaw

LGTM based on code and marvin tests

ravening · 2019-12-23T15:55:19Z

@anuragaw @DaanHoogland can this be merged?

anuragaw · 2019-12-23T16:06:31Z

LGTM to be merged @rakgenius , just need to wait for some commitor's attention to have it in. (I am NOT yet a committor in ACS)

DaanHoogland · 2019-12-24T09:08:43Z

@rakgenius I think you have a seat near to Wei's? ;)

ravening · 2019-12-24T10:04:41Z

@rakgenius I think you have a seat near to Wei's? ;)

@DaanHoogland :P I sit next to him :) thanks for merging

andrijapanicsb · 2019-12-25T18:09:40Z

@DaanHoogland @anuragaw this was merged without an "outsider" testing this (i.e. person different to the author) which I believe we discussed to make sure is happening when possible.

This breaks backward compatibility (in GUI at least) since ipaddress=-1 is sent to the API, instead of omitting this parameter when IP is not selected (which works fine, as before).

@rakgenius can you please fix this in a new PR - or revert this PR and make a new one with the fix included?
FYI I stumbled upon this issues while testing something completely different (i.e. not yet hunting any offending PRs)

ravening · 2019-12-30T08:45:38Z

@andrijapanicsb I will make a new PR to fix this issue.

ravening · 2019-12-30T08:55:44Z

@andrijapanicsb I have created a new PR in #3790

andrijapanicsb · 2019-12-30T15:54:36Z

cool - thx!

Currently in cloudstack, when we click on "Acquire New Ip", it will randomly acquire IP from the pool. With this enhancement, it is possible to select the IP from the drop down IP list of that network. Same thing applies for a VPC as well.

svenvogel added component:networking type:enhancement labels Dec 19, 2019

DaanHoogland added this to the 4.14.0.0 milestone Dec 19, 2019

DaanHoogland approved these changes Dec 19, 2019

View reviewed changes

anuragaw approved these changes Dec 20, 2019

View reviewed changes

anuragaw approved these changes Dec 21, 2019

View reviewed changes

DaanHoogland merged commit 482e7eb into apache:master Dec 24, 2019

Uh oh!

Conversation

ravening commented Dec 18, 2019

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

div8cn commented Dec 20, 2019

Uh oh!

anuragaw left a comment

Choose a reason for hiding this comment

Uh oh!

ravening commented Dec 20, 2019

Uh oh!

ravening commented Dec 20, 2019

Uh oh!

anuragaw commented Dec 20, 2019

Uh oh!

ravening commented Dec 20, 2019

Uh oh!

anuragaw left a comment

Choose a reason for hiding this comment

Uh oh!

anuragaw commented Dec 20, 2019

Uh oh!

blueorangutan commented Dec 20, 2019

Uh oh!

blueorangutan commented Dec 20, 2019

Uh oh!

anuragaw commented Dec 20, 2019

Uh oh!

blueorangutan commented Dec 20, 2019

Uh oh!

anuragaw commented Dec 20, 2019

Uh oh!

blueorangutan commented Dec 21, 2019

Uh oh!

anuragaw left a comment

Choose a reason for hiding this comment

Uh oh!

ravening commented Dec 23, 2019

Uh oh!

anuragaw commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Dec 24, 2019

Uh oh!

ravening commented Dec 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrijapanicsb commented Dec 25, 2019

Uh oh!

ravening commented Dec 30, 2019

Uh oh!

ravening commented Dec 30, 2019

Uh oh!

andrijapanicsb commented Dec 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anuragaw commented Dec 23, 2019 •

edited

Loading

ravening commented Dec 24, 2019 •

edited

Loading