Skip to content

Conversation

@khos2ow
Copy link
Contributor

@khos2ow khos2ow commented Sep 18, 2018

Description

This PR adds Vault integration:

  • IKEV2 VPN implementation
  • TODO

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@khos2ow khos2ow force-pushed the vault-integration branch 2 times, most recently from e8121ac to c483658 Compare September 19, 2018 19:43
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt plugin integration to CA framework, extend/refactor the CA framework as necessary. Several explicit ui elements can be removed, for example the download ca cert button already exists.

@DaanHoogland
Copy link
Contributor

@khos2ow please rebase and re-open if still relevant

@skattoju4
Copy link
Contributor

@DaanHoogland can we re-open this, attempting to revive this effort..

@rohityadavcloud
Copy link
Member

@skattoju3 Sure, or you may submit a new PR as this one may have a lot of conflicts.

@khos2ow
Copy link
Contributor Author

khos2ow commented Apr 22, 2021

@rhtyd: @skattoju4 has already rebased on master and fixed the conflicts on this branch, so it should be safe to reopen this one.

@rohityadavcloud
Copy link
Member

@khos2ow as the PR author you could reopen it yourself too, let me help reopen nonetheless.

@rohityadavcloud
Copy link
Member

@khos2ow @skattoju4 you need to rebase to latest master, PR says 2416 commits.

@khos2ow
Copy link
Contributor Author

khos2ow commented Apr 22, 2021

I think since I was not the person to close this, albeit being the author, I actually couldn't reopen myself. Thanks for reopening!

@skattoju4
Copy link
Contributor

thanks for opening will fix the rebase..

@DaanHoogland
Copy link
Contributor

@skattoju4 @khos2ow, please considder the PR #4904 to prevent conflicts later on.

@pdion891 pdion891 self-requested a review May 5, 2021 13:59
Copy link
Contributor

@pdion891 pdion891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland any significant change from #4904 that we require some code change from this current PR?

#4904

* PKI Manager base class. This will work as a factory to construct Vault or Default
* implementation and pass through the API call to corresponding implementation.
*
* @author Khosrow Moossavi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd is it ok, to have comment in the code with author name? I'm asking because not a lot of commit include such and I'm not sure it is in line with Apache policy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it happens but makes no sense legally (i think). I would be a marker for people to ask questions and spam Khosrow ;)

@DaanHoogland
Copy link
Contributor

@DaanHoogland any significant change from #4904 that we require some code change from this current PR?

#4904

never mind @pdion891 , it is a refactor of the ike vpn to allow for both v1 and v2, also it is merged and no conflicts arose here.

@pdion891
Copy link
Contributor

What is preventing this PR to be merged at this point? I know we have to write doc on how to use it.

@DaanHoogland
Copy link
Contributor

@pdion891 there are conflicts and @rhtyd 👎'd this. nothing else ;)

@pdion891
Copy link
Contributor

Hi @rhtyd, what did you -1 in this PR ?

@pdion891
Copy link
Contributor

ok, found @rhtyd comment;

Basically we need to:

  • create documentation.
  • update UI fields to use existing one from the new UI.
  • make sure it still work fine on latest master branch.

Would something more be missing from this PR ?

@rohityadavcloud
Copy link
Member

Hi @pdion891 well I requested for some changes about two years ago and then did not see any engagement:

Please adapt plugin integration to CA framework, extend/refactor the CA framework as necessary. Several explicit ui elements can be removed, for example the download ca cert button already exists.

Here's what can happen:

  • I don't understand where/how this feature is used (a design doc would be great), or what benefits it brings
  • Does it require a separate/new dependency (external system), then it shouldn't be the default
  • It can explore as a plugin implementation to the CA framework for cert generation/management
  • IKEV2 is already supported in strongswan now afaik (the PR is old needs to be updated to latest main branch)

I came here from the ML thread, I don't see any openvpn use-case (unless that's a separate PR/thing, I did not see openvpn pkg/usage/configuration in this PR or pkg installed in systemvmtemplate).

@pdion891
Copy link
Contributor

well this current PR intent is to leverage IKEv2 from current strongswan running on VR. this is not about OpenVPN.
where do we create Featurespec document nowaday, still in CloudStack wiki ?

@rohityadavcloud
Copy link
Member

@pdion891 ikev2 is supported now, see latest master. If you're extending certificate usage/management, I still think there's some work to be done on this old PR which is ~2yrs old. In its current state, it cannot be simply merged (see the conflict, sql upgrade path changes and rest of the code changes for example). Happy to help review, test, merge this PR if it can be revived in a state which is tested by the author(s) and reaches that point.

@rohityadavcloud
Copy link
Member

Ping @khos2ow is this still valid or can be closed?

@sureshanaparti
Copy link
Contributor

Ping @khos2ow is this still valid or can be closed?

Hi @khos2ow Any update? If this is still valid, Can you fix the conflicts.

@khos2ow
Copy link
Contributor Author

khos2ow commented Jan 3, 2022

@rohityadavcloud @sureshanaparti unfortunately I'm not involved with the project and community anymore, and I'm not entirely up to date with the state of the project as of now on HEAD but I'm almost 100% sure folks at cloud.ca are still heavily relying on this feature. /cc @pdion891 @swill for clarification.

I handed off the project and this PR in particular to @skattoju4 which he rebased this PR some while ago and I think he should be able to follow up on it. I can rebase and fix the conflict as they are, but as I don't have the recent context and roadmap of the project I think it makes more sense for him to do that. Let me know either way.

@rohityadavcloud
Copy link
Member

Thanks @khos2ow, given the PR hasn't made any activities in 3+yrs I'm closing this. Since you're not working on CloudStack anymore, pl re-open this or raise a fresh PR @pdion891 @swill in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants