-
Notifications
You must be signed in to change notification settings - Fork 1.3k
WIP: Vault Integration #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Vault Integration #2850
Conversation
e8121ac to
c483658
Compare
rohityadavcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adapt plugin integration to CA framework, extend/refactor the CA framework as necessary. Several explicit ui elements can be removed, for example the download ca cert button already exists.
|
@khos2ow please rebase and re-open if still relevant |
|
@DaanHoogland can we re-open this, attempting to revive this effort.. |
|
@skattoju3 Sure, or you may submit a new PR as this one may have a lot of conflicts. |
|
@rhtyd: @skattoju4 has already rebased on master and fixed the conflicts on this branch, so it should be safe to reopen this one. |
|
@khos2ow as the PR author you could reopen it yourself too, let me help reopen nonetheless. |
|
@khos2ow @skattoju4 you need to rebase to latest master, PR says 2416 commits. |
|
I think since I was not the person to close this, albeit being the author, I actually couldn't reopen myself. Thanks for reopening! |
|
thanks for opening will fix the rebase.. |
2de1280 to
179c6a7
Compare
|
@skattoju4 @khos2ow, please considder the PR #4904 to prevent conflicts later on. |
pdion891
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaanHoogland any significant change from #4904 that we require some code change from this current PR?
| * PKI Manager base class. This will work as a factory to construct Vault or Default | ||
| * implementation and pass through the API call to corresponding implementation. | ||
| * | ||
| * @author Khosrow Moossavi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhtyd is it ok, to have comment in the code with author name? I'm asking because not a lot of commit include such and I'm not sure it is in line with Apache policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it happens but makes no sense legally (i think). I would be a marker for people to ask questions and spam Khosrow ;)
never mind @pdion891 , it is a refactor of the ike vpn to allow for both v1 and v2, also it is merged and no conflicts arose here. |
|
What is preventing this PR to be merged at this point? I know we have to write doc on how to use it. |
|
@pdion891 there are conflicts and @rhtyd 👎'd this. nothing else ;) |
|
Hi @rhtyd, what did you -1 in this PR ? |
|
ok, found @rhtyd comment; Basically we need to:
Would something more be missing from this PR ? |
|
Hi @pdion891 well I requested for some changes about two years ago and then did not see any engagement: Here's what can happen:
I came here from the ML thread, I don't see any openvpn use-case (unless that's a separate PR/thing, I did not see openvpn pkg/usage/configuration in this PR or pkg installed in systemvmtemplate). |
|
well this current PR intent is to leverage IKEv2 from current strongswan running on VR. this is not about OpenVPN. |
|
@pdion891 ikev2 is supported now, see latest master. If you're extending certificate usage/management, I still think there's some work to be done on this old PR which is ~2yrs old. In its current state, it cannot be simply merged (see the conflict, sql upgrade path changes and rest of the code changes for example). Happy to help review, test, merge this PR if it can be revived in a state which is tested by the author(s) and reaches that point. |
|
Ping @khos2ow is this still valid or can be closed? |
|
@rohityadavcloud @sureshanaparti unfortunately I'm not involved with the project and community anymore, and I'm not entirely up to date with the state of the project as of now on HEAD but I'm almost 100% sure folks at cloud.ca are still heavily relying on this feature. /cc @pdion891 @swill for clarification. I handed off the project and this PR in particular to @skattoju4 which he rebased this PR some while ago and I think he should be able to follow up on it. I can rebase and fix the conflict as they are, but as I don't have the recent context and roadmap of the project I think it makes more sense for him to do that. Let me know either way. |
Description
This PR adds Vault integration:
Types of changes
GitHub Issue/PRs
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
Testing