Skip to content

CLOUDSTACK-9721: Remove deprecated/unused global configuration parameter - consoleproxy.loadscan.interval#1881

Merged
asfgit merged 1 commit into
masterfrom
unknown repository
Feb 21, 2017
Merged

CLOUDSTACK-9721: Remove deprecated/unused global configuration parameter - consoleproxy.loadscan.interval#1881
asfgit merged 1 commit into
masterfrom
unknown repository

Conversation

@sureshanaparti

Copy link
Copy Markdown
Contributor

No description provided.

@koushik-das

Copy link
Copy Markdown
Contributor

Code changes LGTM

@sateesh-chodapuneedi sateesh-chodapuneedi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for code.

@sateesh-chodapuneedi

Copy link
Copy Markdown
Member

@karuturi As this PR is about removal of a deprecated configuration setting which is no more referenced any where in the repo, can we merge this without functional tests?
Or we could make this PR part of a place holder PR so that we can trigger trillian tests more multiple PRs at once?

@rafaelweingartner

Copy link
Copy Markdown
Member

@sureshanaparti Thanks for the cleanup. LGTM
@sateesh-chodapuneedi this is a good question. The changes here remove an attribute of an Enum that is not referenced anywhere. In my opinion, we should not need to run function tests.

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review.

@karuturi

Copy link
Copy Markdown
Member

configuration cleanup. needs BVT

@cloudmonger

Copy link
Copy Markdown

ACS CI BVT Run

Sumarry:
Build Number 365
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

@asfgit
asfgit merged commit da7148a into apache:master Feb 21, 2017
asfgit pushed a commit that referenced this pull request Feb 21, 2017
CLOUDSTACK-9721: Remove deprecated/unused global configuration parameter - consoleproxy.loadscan.interval

* pr/1881:
  CLOUDSTACK-9721: Remove deprecated/unused global configuration parameter - consoleproxy.loadscan.interval

Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants