Cloudstack-9285 exception log addition #1479
Conversation
|
@kiwiflyer shouldn't the |
|
@GabrielBrascher The reason I placed it before is because the follow on log message is basically informing that a reconnect attempt was going to be attempted next. I'm fine reordering those if that's what you'd prefer. |
|
Got it @kiwiflyer. I am good with the way it is. |
|
Simply added a log warning. Built it LGTM |
|
Can you squash your commits and do a This does not change anything that could fail via integration testing, so I don't think we need to run CI against this PR. I have also reviewed this code and it LGTM, so I think this one is ready... |
kiwiflyer
force-pushed
the
9285_exception_log
branch
from
37f8fd1 to
f494d10
Compare
|
@swill Squashed and force pushed. |
|
Thank you @kiwiflyer. Once Jenkins finishes I will merge this since we have the code reviews we need and there is no logical changes that need to be tested (since @pdube has shown the code compiles). |
|
@kiwiflyer Jenkins is failing. Not sure how the error could be related to your code changes, so can you do a Here is the tests that are failing: |
|
@kiwiflyer I can't seem to find that PR discussion you mention. Maybe you got the wrong handle? |
|
I apologize @miguelaferreira. You are correct, I tagged the wrong handle. It was actually @rafaelweingartner. |
|
@kiwiflyer Sorry to do this to you, but would you mind squashing your commits and doing a |
kiwiflyer
force-pushed
the
9285_exception_log
branch
from
9b8dccc to
c729316
Compare
|
Squashed. |
kiwiflyer
force-pushed
the
9285_exception_log
branch
from
c729316 to
698107d
Compare
kiwiflyer
force-pushed
the
9285_exception_log
branch
from
698107d to
5f062f1
Compare
|
@swill - I force pushed it again and Jenkins is finally passing. |
|
@kiwiflyer woohoo!!! thank you for all the support on this. i will merge this in the morning with my next batch. |
Cloudstack-9285 exception log additionAfter discussion with @miguelaferreira on the previous PR related to Cloudstack-9285, we decided on adding additional exception logging for this issue. After adding it, the logs look like this in our lab: 2016-04-07 15:44:03,298 WARN [cloud.agent.Agent] (Agent-Handler-1:null) (logid:7225632a) NIO Connection Exception com.cloud.utils.exception.NioConnectionException: Connection closed with -1 on reading size. <<-- new exception logging 2016-04-07 15:44:03,298 INFO [cloud.agent.Agent] (Agent-Handler-1:null) (logid:7225632a) Attempted to connect to the server, but received an unexpected exception, trying again... << --original logging from previous PR. * pr/1479: Additional exception logging for Cloudstack-9285 Signed-off-by: Will Stevens <williamstevens@gmail.com>
| try { | ||
| _connection.start(); | ||
| } catch (final NioConnectionException e) { | ||
| s_logger.warn("NIO Connection Exception " + e); |
There was a problem hiding this comment.
Since it is unlikely that these two lines will appear in the log sequentially, why aren't these two log messages combined into one WARN message?
7 participants
After discussion with @miguelaferreira on the previous PR related to Cloudstack-9285, we decided on adding additional exception logging for this issue.
After adding it, the logs look like this in our lab:
2016-04-07 15:44:03,298 WARN cloud.agent.Agent (logid:7225632a) NIO Connection Exception com.cloud.utils.exception.NioConnectionException: Connection closed with -1 on reading size. <<-- new exception logging
2016-04-07 15:44:03,298 INFO cloud.agent.Agent (logid:7225632a) Attempted to connect to the server, but received an unexpected exception, trying again... << --original logging from previous PR.