Skip to content

Add Display controller to GPU class check#12959

Open
phiea wants to merge 1 commit intoapache:mainfrom
NetNeutralNetworks:amd-mi210-support
Open

Add Display controller to GPU class check#12959
phiea wants to merge 1 commit intoapache:mainfrom
NetNeutralNetworks:amd-mi210-support

Conversation

@phiea
Copy link
Copy Markdown

@phiea phiea commented Apr 3, 2026 •
edited
Loading

this adds support for the amd instinct mi2xx accelorator cards in the discovery script.

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

runnig it on system with two mi210

How did you try to break this feature and the system with this change?

@phiea
Add Display controller to GPU class check
25b0fca 
this adds support for the amd instinct mi2xx accelorator crards in the discovery script.
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Apr 3, 2026

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@phiea phiea mentioned this pull request Apr 3, 2026
Open
Copilot AI reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the KVM GPU discovery script’s PCI class filtering to recognize additional GPU-like PCI classes, aiming to improve detection of AMD Instinct MI2xx accelerator cards during host discovery.

Changes:

  • Extend the PCI class regex filter to include Display controller entries from lspci -nnm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.00%. Comparing base (e2d18c0) to head (25b0fca).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #12959   +/-   ##
=========================================
  Coverage     18.00%   18.00%           
  Complexity    16464    16464           
=========================================
  Files          5977     5977           
  Lines        537726   537726           
  Branches      66026    66026           
=========================================
  Hits          96839    96839           
  Misses       429968   429968           
  Partials      10919    10919
Flag Coverage Δ
uitests 3.52% <ø> (ø)
unittests 19.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92 vishesh92 linked an issue Apr 3, 2026 that may be closed by this pull request
GPU Discovery not detecting AMD Mi2xx GPUs #12957
Open
vishesh92
vishesh92 approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vishesh92
Copy link
Copy Markdown
Member

vishesh92 commented Apr 3, 2026 •
edited
Loading

@phiea Thanks for the PR and testing with AMD hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@vishesh92 vishesh92 vishesh92 approved these changes

Assignees

No one assigned

Labels

component:kvm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GPU Discovery not detecting AMD Mi2xx GPUs

3 participants

@phiea @vishesh92