Skip to content

merge acs-api-commands project into tools - #11098

Merged
nvazquez merged 56 commits into
apache:mainfrom
pdion891:rn-api-command-diff
Sep 8, 2026
Merged

nvazquez merged 56 commits into
apache:mainfrom
pdion891:rn-api-command-diff

Conversation

@pdion891

@pdion891 pdion891 commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Description

As suggested in the mailing list, here is the merge of acs-api-commands/
which is use to create CloudStack Release Notes to extract new or update api's.

Project renamed into folder tools/apidoc-versions-diff

once this PR merge, the project acs-api-commands/ will be mark as archived/deprecated with a link to this folder.

  • Release note updated.
  • old license file removed.

Perform using git subtree which kept previous commit histories;

git subtree add -P tools/apidoc-versions-diff git@github.com:pdion891/acs-api-commands.git HEAD

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

No.

How did you try to break this feature and the system with this change?

Did not.

@sureshanaparti
sureshanaparti requested a review from Copilot July 4, 2025 12:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the existing acs-api-commands project into the tools/apidoc-versions-diff directory (preserving its history), removes the old license file, and updates the release notes accordingly.

  • Added a subtree for tools/apidoc-versions-diff with diff.txt and diff.json for versions 4.19→4.20 (and earlier).
  • Removed the old license file and updated release notes.
  • No functional changes to existing code; purely a build/CI and tooling import.

Reviewed Changes

Copilot reviewed 31 out of 52 changed files in this pull request and generated 1 comment.

File Description
tools/apidoc-versions-diff/diff-419-420/diff.txt Imported raw API commands diff for CloudStack 4.19→4.20
tools/apidoc-versions-diff/diff-419-420/diff.json Imported structured JSON diff for CloudStack 4.19→4.20
Comments suppressed due to low confidence (2)

tools/apidoc-versions-diff/diff-419-420/diff.txt:17

  • [nitpick] Command descriptions should start with an uppercase verb in third-person singular (e.g., Deletes a backup repository).
    deleteBackupRepository (delete a backup repository)

tools/apidoc-versions-diff/diff-419-420/diff.txt:29

  • The command name uses Nsx rather than NSX; consider renaming to deleteNSXController to reflect the acronym consistently.
    deleteNsxController (delete NSX Controller to CloudStack)


purgeExpungedResources (Purge expunged resources)

deleteNsxController (delete NSX Controller to CloudStack)

Copilot AI Jul 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description reads 'to CloudStack' but should say 'from CloudStack' to accurately reflect removal.

Suggested change
deleteNsxController (delete NSX Controller to CloudStack)
deleteNsxController (delete NSX Controller from CloudStack)

Copilot uses AI. Check for mistakes.
@DaanHoogland

Copy link
Copy Markdown
Contributor

@pdion891 , are you still going through with this?

@weizhouapache weizhouapache added this to the 4.24.0 milestone Jun 29, 2026
@nvazquez

Copy link
Copy Markdown
Contributor

Hi @pdion891 is this PR still in progress?

@pdion891

Copy link
Copy Markdown
Contributor Author

Hi @nvazquez , I have not kept track of this PR recently.
Last time I've check, the CD/CI was complaining about requiring license header on all file.

I will rebase the PR branch...

@pdion891

Copy link
Copy Markdown
Contributor Author

recent changes to get the ci-cd pipeline to work:

  1. removed licence header verification for files in tools/apidoc-versions-diff
  2. fixed lint on all file, endofline/end of file whitespaces
  3. disabled spell check for legacy files

@pdion891
pdion891 marked this pull request as ready for review August 20, 2026 11:49
@pdion891
pdion891 marked this pull request as draft August 20, 2026 11:53
@pdion891
pdion891 marked this pull request as ready for review August 20, 2026 14:56
@pdion891

Copy link
Copy Markdown
Contributor Author

@DaanHoogland @nvazquez , I think this PR is ready. but please review my last comment.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@weizhouapache @winterhazel you are the current RMs (but we can wait till @RosiKyu / @nvazquez ‘ss turn ;)

@pdion891 some release procedure changes on the wiki needed as well?

@pdion891

Copy link
Copy Markdown
Contributor Author

@DaanHoogland , the only reference I found in the wiki would be in this page: https://cwiki.apache.org/confluence/spaces/CLOUDSTACK/pages/30738117/Release+Procedure it also refer to a tool from @swill.

Would there be anything more to add to this PR ?

@DaanHoogland

Copy link
Copy Markdown
Contributor

@DaanHoogland , the only reference I found in the wiki would be in this page: https://cwiki.apache.org/confluence/spaces/CLOUDSTACK/pages/30738117/Release+Procedure it also refer to a tool from @swill.

Would there be anything more to add to this PR ?

I guess if that’s what you found it should be good, tnx @pdion891

@nvazquez

nvazquez commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19140

@nvazquez

nvazquez commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Thanks @pdion891 merging this PR - will report back if any issues with the new versioning (hopefully none 😄 )

@nvazquez
nvazquez merged commit 53d6516 into apache:main Sep 8, 2026
26 of 27 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in CloudStack Testing Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.