Skip to content

JAVA-1639: VersionNumber does not fullfill equals/hashcode contract #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tolbertam merged 1 commit into from
Oct 27, 2017
Merged

JAVA-1639: VersionNumber does not fullfill equals/hashcode contract #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- [new feature] JAVA-1377: Add support for TWCS in SchemaBuilder.
- [improvement] JAVA-1631: Publish a sources jar for driver-core-tests.
- [improvement] JAVA-1632: Add a withIpPrefix(String) method to CCMBridge.Builder.
- [bug] JAVA-1639: VersionNumber does not fullfill equals/hashcode contract.


### 3.3.0
Expand Down
2 changes: 1 addition & 1 deletion driver-core/src/main/java/com/datastax/driver/core/VersionNumber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public boolean equals(Object other) {

@Override
public int hashCode() {
return MoreObjects.hashCode(major, minor, patch, dsePatch, preReleases, build);
return MoreObjects.hashCode(major, minor, patch, dsePatch, Arrays.hashCode(preReleases), build);
}

@Override
Expand Down
9 changes: 9 additions & 0 deletions driver-core/src/test/java/com/datastax/driver/core/VersionNumberTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,15 @@ public void should_order_versions() {
assertOrder("2.0.0+build01", "2.0.0+build02", 0);
}

@Test(groups = "unit")
public void should_treat_same_prerelease_equal() {
VersionNumber version1 = VersionNumber.parse("3.0.15-SNAPSHOT");
VersionNumber version2 = VersionNumber.parse("3.0.15-SNAPSHOT");

assertThat(version1).isEqualTo(version2);
assertThat(version1.hashCode()).isEqualTo(version2.hashCode());
}

private void assertOrder(String version1, String version2, int expected) {
assertThat(VersionNumber.parse(version1).compareTo(VersionNumber.parse(version2))).isEqualTo(expected);
}
Expand Down