Skip to content

301 - Schema metadata API refactor#233

Closed
mpenick wants to merge 11 commits intomasterfrom
301
Closed

301 - Schema metadata API refactor#233
mpenick wants to merge 11 commits intomasterfrom
301

Conversation

@mpenick
Copy link
Contributor

@mpenick mpenick commented Oct 14, 2015

No description provided.

mikefero
mikefero reviewed Oct 16, 2015
View reviewed changes
include/cassandra.h
Copy link
Contributor

@mikefero mikefero Oct 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For C* v1.2.x an 2.0.x cf_id does not exist resulting in the return of a uninitialized id_ (https://github.com/datastax/cpp-driver/pull/233/files#diff-f30001b0d6d7abd11f9acc768a8b0737R240); the CassUuid struct does not define a constructor to to initialize either. Should we define a CASS_UUID_INVALID in the API header and initialize CassUuid as the invalid define?

Or we could document that the meta id is only available for C* 2.1+.

@mikefero mikefero mentioned this pull request Oct 16, 2015
Merged
mikefero pushed a commit that referenced this pull request Oct 20, 2015
Merge pull request #233 from datastax/301
3e23b43
@aholmberg
Copy link
Contributor

aholmberg commented Oct 20, 2015

I'm seeing some kind of corruption in the output of the example:

Error: Cannot add existing keyspace "examples"
Keyspace "annot ":
....
Table "schema_
              ":

The names of each are messed up. Just did some very basic debugging and they seem to be coming back correctly. Have not dug in further... posting here for corroboration.

@mpenick mpenick closed this Oct 22, 2015
@mpenick
Copy link
Contributor Author

mpenick commented Oct 22, 2015

This landed with different commits because I updated the author.

@mpenick mpenick deleted the 301 branch October 22, 2015 18:08
mikefero pushed a commit that referenced this pull request Jul 1, 2019
@mpenick
CPP-764 - Move internal components from namespace cass to `namespac…
53354e9 
…e datastax::internal` (#233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpenick @aholmberg @mikefero