chore(lint): stop Biome walking into git worktrees - #320
Merged
Merged
Conversation
`git worktree add .claude/worktrees/<name>` is the workflow this repo already uses, and every worktree carries its own `biome.json`. Biome 2.5 treats a nested config as an error — "Found a nested root configuration, but there's already a root configuration" — one per worktree, so `make lint` fails outright for anyone with a branch checked out that way. CI never sees it: a fresh clone has no worktrees. `files.includes` scopes which files are checked; this scopes which directories are walked at all. Same 343 files checked before and after, verified by running Biome over `host packages modules` with and without the line. Placed among the existing negations rather than first: a leading `!` pattern makes Biome match nothing, and `!.claude` without the `/**` suffix is the form 2.2+ wants.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
7c63dad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9a7b8970.simple-module-python.pages.dev |
| Branch Preview URL: | https://chore-biome-skip-worktrees.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while verifying
main's gates after today's merges. Not tied to an issue.The problem
git worktree add .claude/worktrees/<name>is the workflow this repo already uses — there are 19 such worktrees on my checkout right now. Each one contains a copy ofbiome.json, and Biome 2.5 treats a nested config as a hard error:One per worktree, and
npx biome ci .exits non-zero, somake lintfails outright for anyone with a branch checked out that way — regardless of whether their own code is clean.CI never sees it: a fresh clone has no worktrees. So this is a local-only failure, and the error message points at
biome migrate --write, which is the wrong remedy entirely.The fix
One line.
files.includesalready scopes which files are checked; this scopes which directories are walked at all.Two details that took a couple of attempts:
!entry makes Biome match nothing (lint/suspicious/noBiomeFirstException).!.claude, not!.claude/**— since 2.2.0 the trailing/**on a folder exclusion is itself flagged (lint/suspicious/useBiomeIgnoreFolder).Verification
Coverage is unchanged — I checked rather than assumed:
And the full run now succeeds with 19 worktrees present:
(344 = the same 343 plus
biome.jsonitself, which the root run includes.)