test: cover the units #295 listed as shipping untested - #319

Closes #295 — the second half. The first half (the two assertions that never ran) closed in #314. Held until #312 and #313 landed, since both touch these files.

What was untested

The three worth reading

user_state / deriveState are the same rule in two languages — deriveState exists because disabling an account from the edit page updates local state without a reload, so the pill has to be recomputed rather than read off the prop it was rendered from. Nothing held them together, so the first edit to either would have drifted them silently. They now share one six-row table written out in both suites, and the Python side asserts that table covers every value in USER_STATES, so a new state added without a case is a failure rather than a gap.

useLeaveGuard was stubbed out by both page suites (router: { on: () => () => {} }), so neither the prompt nor its escape hatch ever ran. The escape hatch is the load-bearing half: the page's own save is an Inertia visit too, and prompting on it would ask "discard your changes?" while saving them.

showEmpty keys on pagination.total, not files.length. A page past the last one renders an empty files array while the bucket is full, so the simpler condition would announce "No files yet" over a full bucket — there is a test for exactly that case. The copy also splits on whether a filter is active, because "No files yet" is wrong and discouraging when the filter is merely too narrow.

_clamp gets its other branch: zero, negative, None, a numeric string, and both bools — bool is an int, so True must not read as a one-second window.

Two corrections to the issue's text

• It says modules/file_storage "has no *.test.tsx at all". No longer true — perf(file_storage): one scan, cached, for the browse screen's bucket totals #307 and fix(ui): give the shared components the behaviour their roles promise #313 added FileTable.test.tsx, format.test.ts and upload-queue.test.ts. Only SelectionFooter and showEmpty were actually missing, and those are what this adds.
• PasswordStrength is indeed already covered; PasswordInput was the gap, as stated.

Verification

• uv run pytest -q — 2973 passed, 60 deselected
• npx vitest run — 463 passed in 56 files (+46)
• ruff format / ruff check / ty check framework modules host / check_file_size.py — pass
• npx biome check . (344 files), npx tsc --noEmit on packages/ui, host/client_app, modules/{users,permissions,file_storage}, check_untranslated_strings.mjs — pass

Note: tsc -p host/client_app needs make gen-pages first — modules.generated.ts is generated and absent in a fresh worktree. Not a change here, but it bites anyone typechecking that workspace in isolation.