switch from using maps and spread operators to for loops so that when… #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… large datasets are used the maximum call stack is not exceeded
|
This LGTM, any reason why it hasn't moved to master? 😍 I've tried this change and worked locally for me on a large dataset where I was having node's call stack issue as well. |
|
You're iterating twice over the array. You could use: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… large datasets are used the maximum call stack is not exceeded
When converting a large object (like ~150k records) to the csv arrays, the maximum call stack gets exceeded by invoking the map callback on the data variable. Instead if we just use a regular for-loop to push the in to the csvInput array, we don't need to invoke a callback for each record. Hope this helps and please let me know if you have any questions :)
Thanks for making this! It's super helpful