Fix(app): the Vesper theme's light mode#9892
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
@sam-huckaby thank you so much for helping with this! Some feedback:
|
|
I also should ask what level of WCAG we intend to support? For contrast levels, I think the orange in here may not be high enough contrast... |
Doesn't have to be AA, maybe A though? Orange does look too low contrast, agreed. |
WCAG A actually doesn't have any contrast requirements, AA is the first level to require them. I'm going to play around with these colors and see if I can get an orange that just barely meets AA, because otherwise we slide pretty far into brown. Vesper is a specifically dark mode theme though, so maybe I can find an earthy mix that feels like a darker vesper for light mode with sort of earth-brown and evergreen highlights. I also want to get a sort of baseline in place for what all styles should be normally overridden in a theme, that way I can apply changes across the board to bring all of the light mode theme variants into a sort of harmony. |
6613ff0 to
8e8b8ad
Compare
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
8e8b8ad to
ba1bf6a
Compare



What does this PR do?
Fixes #9890
Mainly, the focus was on making the tooltip backgrounds white and then updating a few very bright mint colors that will not work on a light background. I went with a deep green that sort of looks like a darker mint color. (Think Andes candies). I also made the orange a little darker for the gray background.
I also updated the border colors between panes to be white, because the pane backgrounds are all gray in Vesper (maybe that should be revisited though)
This is the Theme that @adamdotdevin showed on stream today as an example of why accepting new themes is sometimes dangerous.
How did you verify your code works?
I ran the app locally and used it in my browser.
Screenshot of post-fix colors